Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 8 Aug 2019 21:51:35 +0200 (CEST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Stephen Boyd <sboyd@kernel.org>
cc:     Jonas Gorski <jonas.gorski@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-clk@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
        Michael Turquette <mturquette@baylibre.com>,
        Philippe Mathieu-Daud?? <f4bug@amsat.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings
In-Reply-To: <20190808194821.825AD21743@mail.kernel.org>
Message-ID: <alpine.DEB.2.21.1908082151160.2912@hadrien>
References: <alpine.DEB.2.21.1908081809160.2995@hadrien> <20190808194821.825AD21743@mail.kernel.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Thu, 8 Aug 2019, Stephen Boyd wrote:

> Quoting Julia Lawall (2019-08-08 09:10:53)
> > From: kbuild test robot <lkp@intel.com>
> >
> > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs
> >
> >  Use devm_platform_ioremap_resource helper which wraps
> >  platform_get_resource() and devm_ioremap_resource() together.
> >
> > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
> >
> > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver")
>
> Is it fixing anything? As far as I can tell it's reducing lines of code
> with another function.

No, it doesn't fix anything.

julia

>
> > CC: Jonas Gorski <jonas.gorski@gmail.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
>