Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595AbVLMKHs (ORCPT ); Tue, 13 Dec 2005 05:07:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932594AbVLMKHs (ORCPT ); Tue, 13 Dec 2005 05:07:48 -0500 Received: from mx1.redhat.com ([66.187.233.31]:24485 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932582AbVLMKHr (ORCPT ); Tue, 13 Dec 2005 05:07:47 -0500 Date: Tue, 13 Dec 2005 05:07:15 -0500 From: Jakub Jelinek To: Andrew Morton Cc: ak@suse.de, mingo@elte.hu, dhowells@redhat.com, torvalds@osdl.org, hch@infradead.org, arjan@infradead.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation Message-ID: <20051213100715.GH31785@devserv.devel.redhat.com> Reply-To: Jakub Jelinek References: <20051212161944.3185a3f9.akpm@osdl.org> <20051213075441.GB6765@elte.hu> <20051213075835.GZ15804@wotan.suse.de> <20051213004257.0f87d814.akpm@osdl.org> <20051213084926.GN23384@wotan.suse.de> <20051213010126.0832356d.akpm@osdl.org> <20051213010233.50fce969.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051213010233.50fce969.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1971 Lines: 53 On Tue, Dec 13, 2005 at 01:02:33AM -0800, Andrew Morton wrote: > Andrew Morton wrote: > > > > Thus far I have this: > > > > And this: > > > From: Andrew Morton > > Remove various things which were checking for gcc-1.x and gcc-2.x compilers. > --- devel/arch/arm/kernel/asm-offsets.c~remove-gcc2-checks 2005-12-13 00:51:14.000000000 -0800 > +++ devel-akpm/arch/arm/kernel/asm-offsets.c 2005-12-13 00:53:27.000000000 -0800 > @@ -23,18 +23,13 @@ > #error Sorry, your compiler targets APCS-26 but this kernel requires APCS-32 > #endif > /* > - * GCC 2.95.1, 2.95.2: ignores register clobber list in asm(). > * GCC 3.0, 3.1: general bad code generation. > * GCC 3.2.0: incorrect function argument offset calculation. > * GCC 3.2.x: miscompiles NEW_AUX_ENT in fs/binfmt_elf.c > * (http://gcc.gnu.org/PR8896) and incorrect structure > * initialisation in fs/jffs2/erase.c > */ > -#if __GNUC__ < 2 || \ > - (__GNUC__ == 2 && __GNUC_MINOR__ < 95) || \ > - (__GNUC__ == 2 && __GNUC_MINOR__ == 95 && __GNUC_PATCHLEVEL__ != 0 && \ > - __GNUC_PATCHLEVEL__ < 3) || \ > - (__GNUC__ == 3 && __GNUC_MINOR__ < 3) > +#if __GNUC__ < 2 || (__GNUC__ == 3 && __GNUC_MINOR__ < 3) > #error Your compiler is too buggy; it is known to miscompile kernels. > #error Known good compilers: 2.95.3, 2.95.4, 2.96, 3.3 > #endif Guess #if __GNUC__ == 3 && __GNUC_MINOR__ < 3 #error Your compiler is too buggy; it is known to miscompile kernels. #error Known good compilers: 3.3, 3.4, 4.0 #endif would be better. __GNUC__ < 2 will certainly be errored about in other places and it is bad to suggest compilers that are no longer supported as known good ones. Jakub - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/