Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbVLMKUA (ORCPT ); Tue, 13 Dec 2005 05:20:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932608AbVLMKUA (ORCPT ); Tue, 13 Dec 2005 05:20:00 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:4814 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932607AbVLMKT7 (ORCPT ); Tue, 13 Dec 2005 05:19:59 -0500 Date: Tue, 13 Dec 2005 10:19:38 +0000 From: Christoph Hellwig To: Jakub Jelinek Cc: Christoph Hellwig , Andi Kleen , Andrew Morton , mingo@elte.hu, dhowells@redhat.com, torvalds@osdl.org, arjan@infradead.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation Message-ID: <20051213101938.GA30118@infradead.org> Mail-Followup-To: Christoph Hellwig , Jakub Jelinek , Andi Kleen , Andrew Morton , mingo@elte.hu, dhowells@redhat.com, torvalds@osdl.org, arjan@infradead.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20051212161944.3185a3f9.akpm@osdl.org> <20051213075441.GB6765@elte.hu> <20051213075835.GZ15804@wotan.suse.de> <20051213004257.0f87d814.akpm@osdl.org> <20051213084926.GN23384@wotan.suse.de> <20051213090429.GC27857@infradead.org> <20051213101141.GI31785@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051213101141.GI31785@devserv.devel.redhat.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 26 On Tue, Dec 13, 2005 at 05:11:41AM -0500, Jakub Jelinek wrote: > On Tue, Dec 13, 2005 at 09:04:29AM +0000, Christoph Hellwig wrote: > > > > > > Remove -Wdeclaration-after-statement > > > > > > Now that gcc 2.95 is not supported anymore it's ok to use C99 > > > style mixed declarations everywhere. > > > > Nack. This code style is pure obsfucation and we should disallow it forever. > > Why? It greatly increases readability when variable declarations can be > moved close to their actual uses. glibc changed a lot of its codebase > this way and from my experience it really helps. mentioning glibc and readability in the same sentence disqualies your here, sorry ;-) But serious, having to look all over the source instead of just a block beginning decreases code readability a lot. And if you have to scroll more than a page to the block beginning on a 80x24 terminal means the code needs a refactoring anyway. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/