Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 8 Aug 2019 14:56:16 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Chris Wilson <chris@chris-wilson.co.uk>
cc:     intel-gfx@lists.freedesktop.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Sedat Dilek <sedat.dilek@gmail.com>,
        Hugh Dickins <hughd@google.com>,
        Matthew Auld <matthew.auld@intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
In-Reply-To: <20190808172226.18306-1-chris@chris-wilson.co.uk>
Message-ID: <alpine.LSU.2.11.1908081447080.10003@eggly.anvils>
References: <20190808172226.18306-1-chris@chris-wilson.co.uk>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 8 Aug 2019, Chris Wilson wrote:
> +	 * By creating our own shmemfs mountpoint, we can pass in
> +	 * mount flags that better match our usecase.
> +	 *
> +	 * One example, although it is probably better with a per-file
> +	 * control, is selecting huge page allocations ("huge=within").

s/within/within_size/

Not that either of us is recommending that direction,
but since it's mentioned, better to give the correct name.

> +	 * Currently unused due to bandwidth issues (slow reads) on Broadwell+.

Thanks,
Hugh