Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932076AbVLMMjc (ORCPT ); Tue, 13 Dec 2005 07:39:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750967AbVLMMjc (ORCPT ); Tue, 13 Dec 2005 07:39:32 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:40400 "EHLO palinux.hppa") by vger.kernel.org with ESMTP id S1750829AbVLMMjb (ORCPT ); Tue, 13 Dec 2005 07:39:31 -0500 Date: Tue, 13 Dec 2005 05:39:30 -0700 From: Matthew Wilcox To: David Howells Cc: Andrew Morton , torvalds@osdl.org, hch@infradead.org, arjan@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation Message-ID: <20051213123930.GI9286@parisc-linux.org> References: <20051212161944.3185a3f9.akpm@osdl.org> <23765.1134470899@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23765.1134470899@warthog.cambridge.redhat.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 20 On Tue, Dec 13, 2005 at 10:48:19AM +0000, David Howells wrote: > > > +#define is_mutex_locked(mutex) ((mutex)->state) > > > > Let's keep the namespace consistent. mutex_is_locked(). > > But that's a poor name: it turns it from a question into a statement:-( Ah, but look at it in context of how it's used: if (is_mutex_locked()) That's gramatically incorrect! if (mutex_is_locked()) much better. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/