Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp7653354ybh; Thu, 8 Aug 2019 20:41:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqxjxKZM3jqCcGvEG8DvC0TRDtPwk1Hyp29i18hp6bv0+K1AOuLr5WIw5gPvz2qlBFN/QdJ/ X-Received: by 2002:a17:902:b28:: with SMTP id 37mr1468658plq.2.1565322073261; Thu, 08 Aug 2019 20:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565322073; cv=none; d=google.com; s=arc-20160816; b=dLe465Hfv2FF/XWczzMbGOe57LrGQhQPdX43wSJmNaXGkiYV3bGk6QM7TcO++FK8RF wvaEJrSBVYdOlOBsU1RrBmG3UJI5SLbZRBTuQ+j2DnMQXyUjnZCRkhR6TfoqV3rJZxcW cQxbrQECPQCLQa2QKa9YyV8FUHn9fJqdJBdhBvFqYUabv6mmlEyW5EBXU++bqtKbs+3a JaIb6kwjhkOlohTWMv1n90aoDTnCIBLR7ld5Gdkq6w4GoYcHSxPGvVX59z6nCIsaarHR lowxwee8pu+TB7+55y8SDatjz7T9Iwq1yCNniF50OWKWfkhqZw+IqhPP4+Kfr6yv/25Z Wvrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=65aYqAVIIYjhyCmnyqV/5PNvkM6BEAj6E5sBAAyQwCc=; b=JpqcnK6LVmvZSjcr8uZy6JavSpeFY0hjAHbLRyGJJh/Pm42oYsplT6/wYuvfx8tSiH EsqP7HdXa1VZzbEKrmjg+or5/wHAmrVwaK9161Ox/s7af9mEpy2MU4UOsorHDve1SCs3 wW5Znk5o0wGOCuLR3N/d4+yQb2tqPyMYcXmQJ/W0UlJ7fQBpuWx3A4uX8OQlDalQyoHB 4akiVJ0ZQQ6SaSiA3PK6I4NTrECqlaOgm7VCZv97VwAPBFU3v2CInoZcr3BDPHALUCY6 ucQGz344d/i3W6T7u0wh9izBiB1n4atXdUwwKSU5e/Lfo3IBgA26l6bb2NkkRnaMz6sZ oYHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=GtsqRxeL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6si16651398pgk.193.2019.08.08.20.40.57; Thu, 08 Aug 2019 20:41:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=GtsqRxeL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405167AbfHIDjo (ORCPT + 99 others); Thu, 8 Aug 2019 23:39:44 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36537 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405098AbfHIDjo (ORCPT ); Thu, 8 Aug 2019 23:39:44 -0400 Received: by mail-pg1-f193.google.com with SMTP id l21so45135154pgm.3 for ; Thu, 08 Aug 2019 20:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=65aYqAVIIYjhyCmnyqV/5PNvkM6BEAj6E5sBAAyQwCc=; b=GtsqRxeLoqj8K/ZiX15WNEvzIG7f3782O540QxuRkI9DX/f9lKPiHGZrCibf2mC43C L2c1x+ZZFrRF3TCiOzo6TYY0NVINPIv0vD0NqH2yN1WTjHQ3QCAifRuEi6yTTwMmjYK+ gfVd9kz+jmv9glukworuJ+yoqetHZGWKiBvlSswDQIYycGH8fp8Ct3TzcLccWuuzQkjQ lv6CLMX/VIcgopNP1SK2XnAlqTU7d9I1Q1Ogy/DMqVNRQYJ6aptJZdXwDeAEISDQC9sE b6/N6G05TMvxVMTRzRmiWoVtnlikt6IM13dFz6WbuhRdrmCLB58kwoEORyaNQPD37+j/ Dckg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=65aYqAVIIYjhyCmnyqV/5PNvkM6BEAj6E5sBAAyQwCc=; b=SzGjwQ/UuZA8Pyi6AruMhhR/6L+EEL+kli+U07GzGZIvqN4lzJXSiPIe/01G6f62c0 0adKE+sZsyrYlW1mF3z0RmVl+PRoNG1OzNIvqQlaQObE2r8gWnpZSpfDD04rXs0z02Ni H0AJYROH13HtAL33FtGjuv9cplk2Xo0N9NQe7bW6wC9cGeUlfuIfJXjDaRScEwMFVhIt cU8h1atApRccA8ZetCuhqWu+esygdufO0ftK8+4/xMdpjJIPNlNbPitTMV+355ztaVLU Lt9oTR+xQzxGXejBgxVJrfa7SXu+aJVFC4MiLCrPiM91jlZGgu72sCrdeB1DHN1pqnA+ 0kUw== X-Gm-Message-State: APjAAAVFQqNvfxs5VPpEoPzJuagVDmWlQ6tD9ZGKEf5jI7ImRyqVuh3A sO3lfqYTvhy8k53DL00VRipr8w== X-Received: by 2002:a63:481c:: with SMTP id v28mr15527467pga.50.1565321983685; Thu, 08 Aug 2019 20:39:43 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:83a1:3965:6e7a:8c2:c21b? ([2605:e000:100e:83a1:3965:6e7a:8c2:c21b]) by smtp.gmail.com with ESMTPSA id j1sm129386216pgl.12.2019.08.08.20.39.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 20:39:42 -0700 (PDT) Subject: Re: [PATCH v2] loop: Add LOOP_SET_DIRECT_IO to compat ioctl To: Alessio Balsini , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dvander@gmail.com, elsk@google.com, gregkh@linuxfoundation.org, joelaf@google.com, kernel-team@android.com References: <20190807004828.28059-1-balsini@android.com> From: Jens Axboe Message-ID: <4dc06fb1-df3c-5887-725a-0d20c3291528@kernel.dk> Date: Thu, 8 Aug 2019 20:39:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190807004828.28059-1-balsini@android.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/6/19 5:48 PM, Alessio Balsini wrote: > Enabling Direct I/O with loop devices helps reducing memory usage by > avoiding double caching. 32 bit applications running on 64 bits systems > are currently not able to request direct I/O because is missing from the > lo_compat_ioctl. > > This patch fixes the compatibility issue mentioned above by exporting > LOOP_SET_DIRECT_IO as additional lo_compat_ioctl() entry. > The input argument for this ioctl is a single long converted to a 1-bit > boolean, so compatibility is preserved. Applied, thanks. -- Jens Axboe