Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp7720279ybh; Thu, 8 Aug 2019 22:08:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxS06Y0YTFbON15g13dFOq7vdUxpVb6EFrL6GNuOHpHkJhQGTRetVafrMpRr3JhF+Zfm83c X-Received: by 2002:a17:902:20c2:: with SMTP id v2mr6088967plg.209.1565327306324; Thu, 08 Aug 2019 22:08:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565327306; cv=none; d=google.com; s=arc-20160816; b=0Tk9V+v2b5wUKcpBRNH0FRBRVKQhHZQi1Lp87+3rez2+mM6GUkg3QOHdwZCM4udROU +946a0WhcuavhUSOPRYmXaX16BpYLRS3I10wZYbG4JD2xmtxVqmPiTSmp7bvpD1OOiH+ bpQMccd3qyPs1uDn5k3kOHiG7YhVC4psbHCer7JslHfGvIz5zixUxJhLiEB3mTbXPFQu 4lfBO56RoYHI+q0bNYnPHQM2zf8TkddwJ1vctC2Qjl//4IvsZfkXj0fqC7RJJiG6yyLq f6TA3sm5drUNS58ICiKiFHlz840j1aGbttZH+Ds8zemU+PK7HP6Dtw5PlYVgnC7YZ56l 121w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kVzUqtekZuvA5BQ/F5kz5AfZPCoFQKrYDYF8a2UR6YY=; b=eJzkvsInupJdZGmPcoLxzX9B1KnXbqfwCxm12W7yVsMb0O4yOj+cRAImY3pVL88PrU VZtTSBkn9iU1OVN+hIqtTKHvEHNXF1pAdPHC1b4GhOKbxLTuD41RdPS1Oxd+O1P99eKD ZRb7S88fVU1AjmKGdBTSCPqXHHnYcHBcLrYbyTM5bdbjV4jpFsrWpCRqrktffCAjp/Zp uHo5GuWD1t2+mHOFcKKqb/24KIPH+nSc+YsMX3z2ryb4pTmg7EbLp3qvcydLsU9ix0Gc mb0srl+aCKF6k1tc+9P31X44lHzqAhZW8whVgP1u2OaZBPlcX6a1z4dMV0vaPKnuF0/z 5CKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q25si51164915pgv.114.2019.08.08.22.08.08; Thu, 08 Aug 2019 22:08:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405268AbfHIFBM (ORCPT + 99 others); Fri, 9 Aug 2019 01:01:12 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfHIFBM (ORCPT ); Fri, 9 Aug 2019 01:01:12 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D07D140505DB; Thu, 8 Aug 2019 22:01:11 -0700 (PDT) Date: Thu, 08 Aug 2019 22:01:10 -0700 (PDT) Message-Id: <20190808.220110.894522042255176514.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: vinicius.gomes@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: sched: sch_taprio: fix memleak in error path for sched list parse From: David Miller In-Reply-To: <20190806224540.24912-1-ivan.khoronzhuk@linaro.org> References: <20190806224540.24912-1-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 08 Aug 2019 22:01:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Khoronzhuk Date: Wed, 7 Aug 2019 01:45:40 +0300 > In error case, all entries should be freed from the sched list > before deleting it. For simplicity use rcu way. > > Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler") > Acked-by: Vinicius Costa Gomes > Signed-off-by: Ivan Khoronzhuk Applied and queued up for -stable, thank you.