Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp7729736ybh; Thu, 8 Aug 2019 22:20:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOUHU1zlfTcXjuz1yRH5o4nV72Hm5m/mq59Q1rOeOlLpzMWy9jWnt68jIoNUJSWVg1UKLF X-Received: by 2002:a63:3203:: with SMTP id y3mr16072904pgy.191.1565328007329; Thu, 08 Aug 2019 22:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565328007; cv=none; d=google.com; s=arc-20160816; b=FUQrsRqw5xN9A31pKuMH3YAOkmY6bO0aAk9V7uzED1p83EaGEvhQKPOMy3LhRElgSM zYy6Ky7e4qCNIyvkeeFhlKg19ZVZ/eHcSHPpOrzFVRbFME5EvGt+PB8U29TnwrkdiCjp xwOeOnzqp0vS7eI7KzScqHsgDs4LFk0VRGOWTFgH8AvRs5uzMf+SnRHG6Ler8ybeTgtw UNv86yCO9o5RdHWrvBPsjg7kd3wi82Q76cEJ97QccBhvag9KAtQLMFSyEy20bJgGvNVr A+7fqhbKAqYZr4XRv0BWdQb4U6kkfP/IBzYNAzE1OCESOZRjBv9LpTV9AicF0X8LbCN6 UHJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JIPto5BrsYfyxRbHbVWlygDZRL8sTI9R7GvBG0lC29w=; b=lS0/EVa2ecRW7P3LgbHL5RiWPygwYhdZHcm2Luhjnyz6VIqtYPudyGHXNBGwi1cZ+y 2iSnGnJ+S/Qxgk2zal2jsyvVZWEBX9TYXm2AdEO6vgi4pI7RzDFV8WoansOS5OyfnRxT 593dF6oqOGbpg3TAWta0+o4fnCBT1//PmoIEv5Rzq8RWmIreLMuuNvO6MU7YpkqtG+b/ g/HhiHx0JDhfyLyzP/HJ1QqiBA6q6xGCc8/7X+GvCPz0LbebL8WuVfbn/XvV7NJwReNt TW2k9cpUenw+1SS3AipKbVVbHQ995yDyViED9xnFyFWZZdn/LdAH29YoxMAi5QSJ2IfP PLpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v4si45174171pgf.470.2019.08.08.22.19.50; Thu, 08 Aug 2019 22:20:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405439AbfHIFRJ (ORCPT + 99 others); Fri, 9 Aug 2019 01:17:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56042 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728823AbfHIFRJ (ORCPT ); Fri, 9 Aug 2019 01:17:09 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 951B31428D99E; Thu, 8 Aug 2019 22:17:08 -0700 (PDT) Date: Thu, 08 Aug 2019 22:17:08 -0700 (PDT) Message-Id: <20190808.221708.1683611820360022260.davem@davemloft.net> To: huangfq.daxian@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock_irq in IRQ context From: David Miller In-Reply-To: <20190807074300.23135-1-huangfq.daxian@gmail.com> References: <20190807074300.23135-1-huangfq.daxian@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 08 Aug 2019 22:17:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fuqian Huang Date: Wed, 7 Aug 2019 15:43:00 +0800 > @@ -372,8 +372,9 @@ static void tsi108_stat_carry(struct net_device *dev) > { > struct tsi108_prv_data *data = netdev_priv(dev); > u32 carry1, carry2; > + unsigned long flags; Please preserve reverse christmas tree ordering of local variables. Thank you.