Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pankaj Bansal <pankaj.bansal@nxp.com>
To:     Schrempf Frieder <frieder.schrempf@kontron.de>,
        Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Ashish Kumar <ashish.kumar@nxp.com>
Subject: RE: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
 nodes
Thread-Topic: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
 nodes
Thread-Index: AQHU3yvM8yMRGyNksEqd6u7/XzJALabzNSzg
Date:   Fri, 9 Aug 2019 06:18:47 +0000
Message-ID: <VI1PR0401MB2496C44034AB6DB5F5379904F1D60@VI1PR0401MB2496.eurprd04.prod.outlook.com>
References: <20190320143800.3555-1-frieder.schrempf@kontron.de>
 <20190320143800.3555-2-frieder.schrempf@kontron.de>
In-Reply-To: <20190320143800.3555-2-frieder.schrempf@kontron.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bee526f-0cf0-4654-4493-08d71c9170a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2019 06:18:48.0063
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QRpS0K584wRpT3MGi7DwS7MZBJGjW8ZzRKP4QhczzjPxjneCn/s9BlQpffumlLMVw8/NTSbhrcpYSkUukv9ooA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2415
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn/Leo,

Removing the "big-endian" property has caused problems in our UEFI firmware=
.
In UEFI, we use the device tree to detect and use the qspi controller and f=
lashes attached to it.
We don't maintain a list of platforms like linux driver.

Can you please revert the endianness change from linux mainline ?

Regards,
Pankaj Bansal

> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org>
> On Behalf Of Schrempf Frieder
> Sent: Wednesday, 20 March, 2019 08:08 PM
> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>
> Cc: Schrempf Frieder <frieder.schrempf@kontron.de>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
> nodes
>=20
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>=20
> After switching to the new FSL QSPI driver the properties 'fsl,qspi-has-s=
econd-
> chip' and 'big-endian' are not used anymore.
>=20
> The driver now uses the 'reg' property to determine the bus and the chips=
elect.
> The endianness is selected by the driver depending on which SoC is used.
>=20
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
>  2 files changed, 3 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 6fd6116509cc..2fb8138c6bb0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -296,7 +296,6 @@
>  			interrupts =3D <0 99 0x4>;
>  			clock-names =3D "qspi_en", "qspi";
>  			clocks =3D <&clockgen 4 0>, <&clockgen 4 0>;
> -			big-endian;
>  			status =3D "disabled";
>  		};
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index cb7185014d3a..b0ef08b090dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -215,8 +215,6 @@
>  			interrupts =3D <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names =3D "qspi_en", "qspi";
>  			clocks =3D <&clockgen 4 1>, <&clockgen 4 1>;
> -			big-endian;
> -			fsl,qspi-has-second-chip;
>  			status =3D "disabled";
>  		};
>=20
> --
> 2.17.1