Date: Tue, 13 Dec 2005 13:52:05 +0000
From: Al Viro <viro@ftp.linux.org.uk>
To: JANAK DESAI <janak@us.ibm.com>
Cc: chrisw@osdl.org, dwmw2@infradead.org, jamie@shareable.org,
       serue@us.ibm.com, mingo@elte.hu, linuxram@us.ibm.com, jmorris@namei.org,
       sds@tycho.nsa.gov, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 7/9] unshare system call : allow unsharing of namespace
Message-ID: <20051213135205.GP27946@ftp.linux.org.uk>
References: <1134442736.14136.128.camel@hobbs.atlanta.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1134442736.14136.128.camel@hobbs.atlanta.ibm.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 653
Lines: 15

On Mon, Dec 12, 2005 at 10:00:09PM -0500, JANAK DESAI wrote:
> 
> [PATCH -mm 7/9] unshare system call: allow unsharing of namespace

You need a pointer to new fs_struct, since that's what will be modified.
As it is, you are modifying ->root, etc. of old fs_struct, which is OK
only when it's not shared.

	What you need is to pass new_fs ? new_fs : current->fs as a separate
argument to your dup_namespace().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/