Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>
To:     Will Deacon <will@kernel.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Leo Li <leoyang.li@nxp.com>,
        "jslaby@suse.com" <jslaby@suse.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Cosmin Stefan Stoica <cosmin.stoica@nxp.com>,
        Larisa Ileana Grigore <larisa.grigore@nxp.com>
Subject: Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234
Thread-Topic: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234
Thread-Index: AQHVTpc0N7PGKATl60WX/HSnUpERYA==
Date:   Fri, 9 Aug 2019 09:45:40 +0000
Message-ID: <VI1PR0402MB2863B3E3E2F93CBA8ADB96E5DFD60@VI1PR0402MB2863.eurprd04.prod.outlook.com>
References: <20190802194702.30249-1-stefan-gabriel.mirea@nxp.com>
 <20190802194702.30249-6-stefan-gabriel.mirea@nxp.com>
 <20190808080832.nleult5bknmzr3ze@willie-the-truck>
 <VI1PR0402MB28635661A4A294EC6F01095EDFD70@VI1PR0402MB2863.eurprd04.prod.outlook.com>
 <20190808171711.nk7ljqkugtketu4q@willie-the-truck>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b1ce9e63-d687-4377-7fc5-08d71cae56dd
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2019 09:45:40.2418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mQTYDFCG5FWbj/6dT0j0JlhWuLrK/tfyIhrltz1ZxBCa0EY/7PVgvAkHY1XrM+gcgsCUj1yFevooUHTaefHnohN++xPwd9OHH3B5rjhTQTE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3487
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/8/2019 8:17 PM, Will Deacon wrote:=0A=
> On Thu, Aug 08, 2019 at 12:47:00PM +0000, Stefan-gabriel Mirea wrote:=0A=
>> On 8/8/2019 11:08 AM, Will Deacon wrote:=0A=
>>> On Fri, Aug 02, 2019 at 07:47:23PM +0000, Stefan-gabriel Mirea wrote:=
=0A=
>>>> +             linflex,<addr>=0A=
>>>> +                     Use early console provided by Freescale LinFlex =
UART=0A=
>>>> +                     serial driver for NXP S32V234 SoCs. A valid base=
=0A=
>>>> +                     address must be provided, and the serial port mu=
st=0A=
>>>> +                     already be setup and configured.=0A=
>>>=0A=
>>> Why isn't earlycon=3D sufficient for this?=0A=
>>=0A=
>> "earlycon=3D" is not actually supported. I will fix this in the next=0A=
>> version by adding a /chosen/stdout-path to the dts. The compatible=0A=
>> string provided to OF_EARLYCON_DECLARE will also be changed from=0A=
>> "fsl,s32v234-linflexuart" to "fsl,s32-linflexuart" to match the one in=
=0A=
>> the device tree nodes. I missed this after importing a rename from our=
=0A=
>> codebase.=0A=
>>=0A=
>> Should I remove this addition from kernel-parameters.txt after that?=0A=
> =0A=
> Yes, if you can use earlycon instead, then you can drop your custom optio=
n=0A=
> entirely and therefore there's no need to document it either.=0A=
=0A=
Can you please clarify what you mean by "drop your custom option"? The=0A=
"linflex" option documented in the paragraph is the name of the=0A=
earlycon_id declared via "OF_EARLYCON_DECLARE(linflex, ...)". We have=0A=
not done anything particular to accept it in the parameter value.=0A=
=0A=
We do use earlycon (e.g. "earlycon=3Dlinflex,0x40053000"), we just do not=
=0A=
support an empty value after "=3D", which needs to be fixed as I=0A=
understand, because it does not respect the comment[1] about ARM64.=0A=
=0A=
Regards,=0A=
Stefan=0A=
=0A=
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree=
/Documentation/admin-guide/kernel-parameters.txt?h=3Dv5.3-rc3#n980=0A=