Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] cpufreq: drivers: Enable frequency invariance in
 qcom-cpufreq-hw
To:     Quentin Perret <quentin.perret@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, rjw@rjwysocki.net,
        viresh.kumar@linaro.org, agross@kernel.org
References: <20190808131857.21082-1-douglas.raillard@arm.com>
 <20190808173230.53ddupihjlr6uvne@queper01-lin>
From:   Douglas Raillard <douglas.raillard@arm.com>
Organization: ARM
Message-ID: <14762a81-a81d-d05f-b42a-495dacb28168@arm.com>
Date:   Fri, 9 Aug 2019 11:16:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190808173230.53ddupihjlr6uvne@queper01-lin>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB-large
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Quentin,

On 8/8/19 6:32 PM, Quentin Perret wrote:
> Hi Douglas,
> 
> On Thursday 08 Aug 2019 at 14:18:57 (+0100), Douglas RAILLARD wrote:
>> Add calls to arch_set_freq_scale() in qcom-cpufreq-hw driver to enable
>> frequency invariance.
> 
> Is there a patch 2/2 ?

That slipped through when format-patch-ing unrelated commits, there is no 2nd patch.

>>
>> Signed-off-by: Douglas RAILLARD <douglas.raillard@arm.com>
>> ---
>>   drivers/cpufreq/qcom-cpufreq-hw.c | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
>> index 4b0b50403901..3bd3b8b268d9 100644
>> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
>> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
>> @@ -34,9 +34,12 @@ static int qcom_cpufreq_hw_target_index(struct cpufreq_policy *policy,
>>   					unsigned int index)
>>   {
>>   	void __iomem *perf_state_reg = policy->driver_data;
>> +	unsigned long freq = policy->freq_table[index].frequency;
>>   
>>   	writel_relaxed(index, perf_state_reg);
>>   
>> +	arch_set_freq_scale(policy->related_cpus, freq,
>> +			    policy->cpuinfo.max_freq);
>>   	return 0;
>>   }
>>   
>> @@ -63,6 +66,7 @@ static unsigned int qcom_cpufreq_hw_fast_switch(struct cpufreq_policy *policy,
>>   {
>>   	void __iomem *perf_state_reg = policy->driver_data;
>>   	int index;
>> +	unsigned long freq;
>>   
>>   	index = policy->cached_resolved_idx;
>>   	if (index < 0)
>> @@ -70,7 +74,11 @@ static unsigned int qcom_cpufreq_hw_fast_switch(struct cpufreq_policy *policy,
>>   
>>   	writel_relaxed(index, perf_state_reg);
>>   
>> -	return policy->freq_table[index].frequency;
>> +	freq = policy->freq_table[index].frequency;
>> +	arch_set_freq_scale(policy->related_cpus, freq,
>> +			    policy->cpuinfo.max_freq);
>> +
>> +	return freq;
>>   }
>>   
>>   static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
>> -- 
>> 2.22.0
> 
> Reviewed-by: Quentin Perret <quentin.perret@arm.com>
> 
> Thanks,
> Quentin
> 

Thanks,
Douglas