Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 9 Aug 2019 16:11:14 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add devres versions of
 regulator_enable/disable
Message-ID: <20190809151114.GD3963@sirena.co.uk>
References: <20190809030352.8387-1-hslester96@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5"
Content-Disposition: inline
In-Reply-To: <20190809030352.8387-1-hslester96@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--+KJYzRxRHjYqLGl5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 09, 2019 at 11:03:52AM +0800, Chuhong Yuan wrote:
> I wrote a coccinelle script to detect possible chances
> of utilizing devm_() APIs to simplify the driver.
> The script found 147 drivers in total and 22 of them
> have be patched.

> Within the 125 left ones, at least 31 of them (24.8%)
> are hindered from benefiting from devm_() APIs because
> of lack of a devres version of regulator_enable().

I'm not super keen on managed versions of these functions since they're
very likely to cause reference counting issues between the probe/remove
path and the suspend/resume path which aren't obvious from the code, I'm
especially worried about double frees on release.

--+KJYzRxRHjYqLGl5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1NjREACgkQJNaLcl1U
h9BTwQf/eqfid6pFWWsC2XkcNrM+hxfvfGZELEmM6UU6BNiNRv5wbAWCDwfoW5ol
6NsV3LufKaBWz9ETFQGoDzXaUP6Vzfz+qz6/kcnRBT4CCt169NopcB4+92kPhO4s
lHlHczBN26rx9pQoEJNSYwXdNrhqgcjywUtWX4sTw2yzP+QSxMUcYIlGYkrh8LBl
laGfWsPWJJJxwcLqtP/iEVS1iBb5BJ9dvyfnWxpSLscg7QDxGQwgB/yiwTHE6lUY
C9ivrG/b0VUj4q8rY3kcRJZgRqNhLWYK0LtBJVvRPpulgeE66c1vtQ3IgTyAAlia
hd4LtLSWpAZ7r2s0Qe0jH2ol73qHmQ==
=HCBh
-----END PGP SIGNATURE-----

--+KJYzRxRHjYqLGl5--