Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp462165ybl; Fri, 9 Aug 2019 08:34:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxs9AYqAV12tuAksu4ZRl+5E5/scXAUC3Ce4A7G1zLPGyjGdNrJw8Dwarq6/9MMi+ZKVYDr X-Received: by 2002:a63:1c22:: with SMTP id c34mr17940252pgc.56.1565364866588; Fri, 09 Aug 2019 08:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565364866; cv=none; d=google.com; s=arc-20160816; b=JgTa5VCHTMZeHVlMX4FHvsmq9W1NCUfhWXl2Hpu3yLi8UISbXaL45Xcd1p7q7kbsTx B7l1xKRau++BueMB4z1Og4pXE8G1dKlGTKtu6NNeNRM1eQIGcsNl+h/Kdci/b3Pppj1b IQAFDWv0Dr8rkrozcFV6ZLclDCvRdSUQvWXKhe3162i/E2HSnQoJG9ljy18DslxrvS8u hAGe6Vz1Ac5AK/SUsga7D2u5E6yR1JXSrwUIYbPz6NIqw1FucU+AB5B85NuNRlePCnUw 7FK0ggpObSB4NRrbNUk3uJc/j+jZJC27tafYc9/mo2SDGhjvO/2yEGp5Kfdz6ZwdCT/e 6cSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:references:cc:to:from:subject; bh=j5xxGPN8deZMZv3leb17VRlxtS8w9kqxa/iotjFPlZU=; b=bhlYzZkIKuLiPhJucNSdpqfrjZQ6vIcJAINGM23eCjqNq+cE/+ZXMxsn+GHVdvHdFQ C/RJxMeHMetzuz+p+xbECPMRSJLwqBeMgSRBgEeRavfm9NU2T7RX3sShJM+YDWfU2w4O iQfFFJ3/Oji+sC2t3I349pHU23MiBHYJ9TC5wF8T0hK0na9x9zgB6LHUiVwIWH1l+t8z WoXCWFMDmCB+tzOIgk+Sye+5BBELERpFhktryjIkmBVeLoC5Nhko2b3umfM8FbxvNm2G bbcToBioi+zadXAjxtFljtn9fipDw3nXdz6nCxMobtA+Or5w5AwPxTFkQlfvr6FaiCq4 g86A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9si58537666pfm.236.2019.08.09.08.34.05; Fri, 09 Aug 2019 08:34:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436603AbfHIPbd (ORCPT + 99 others); Fri, 9 Aug 2019 11:31:33 -0400 Received: from mga01.intel.com ([192.55.52.88]:28149 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbfHIPbd (ORCPT ); Fri, 9 Aug 2019 11:31:33 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 08:31:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,364,1559545200"; d="scan'208";a="326657867" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2019 08:31:32 -0700 Received: from [10.252.0.91] (abudanko-mobl.ccr.corp.intel.com [10.252.0.91]) by linux.intel.com (Postfix) with ESMTP id 8BED45801AB; Fri, 9 Aug 2019 08:31:29 -0700 (PDT) Subject: [PATCH v1 3/3] perf report: prefer dwarf callstacks to LBR ones when captured both From: Alexey Budankov To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , Kan Liang , "Jin, Yao" , linux-kernel References: Organization: Intel Corp. Message-ID: Date: Fri, 9 Aug 2019 18:31:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Display dwarf based callchains when Perf trace contains as raw thread stack data as LBR callstack data. Signed-off-by: Alexey Budankov --- tools/perf/builtin-report.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index d4288dcce156..5ecac3a1ed5b 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -1271,6 +1271,8 @@ int cmd_report(int argc, const char **argv) has_br_stack = perf_header__has_feat(&session->header, HEADER_BRANCH_STACK); + if (perf_evlist__combined_sample_type(session->evlist) & PERF_SAMPLE_STACK_USER) + has_br_stack = false; setup_forced_leader(&report, session->evlist); -- 2.20.1