Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp679515ybl; Fri, 9 Aug 2019 12:01:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMBzQHm0eRqIGEDm4JT0e1M7lXXoEIsPXVoinG+MBPHwkcGUT3jV0PI9XYbRWdHq+kaz9f X-Received: by 2002:aa7:9407:: with SMTP id x7mr23781913pfo.163.1565377292493; Fri, 09 Aug 2019 12:01:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565377292; cv=none; d=google.com; s=arc-20160816; b=kVH0LiTFILXn2L0bS1iWzSN/Kws6Na5N7VC4+hYUIt1YYBezU3wNXPMmN41MtuUkTl c4rNA8qg7+vEj98BSwdgi+abLAjY2J4vkXbSyyi3xrcH2F/CI9gk8H+68pmCIQJPzIo5 64a49mUWtrVDuxqVDzdmFYbNtLwaVaqC2+lOC4Z7f3X+2g9duEBTHFvCldnoXozmg/S8 Xg09W6nUTleZ1RQhUTN7LEfT3hYWVMhzwWeuk1qWFJKGpj4sUoBS4BIjfCuDr6MOvvey Ar0jqcw5WEiD+2hMKPtfj2ck+ciM/FIVFrNJOAVIL4xQx1HFzKiBG6koP6fDlFm8jx1w NymA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=CnlqdyD46svGTkx9duUa9OkYwIQyEdM/+67D9ADvgXk=; b=Ov9T0GvRejC1MKPlVTsN1XPbSgHIrKp1IwhNUKtMuW6jBw7P9ZwUOA/jmgJI+FHm+W BgIW1lpvJQEgGvWsGCr/DZJxnM91Dytb57Gedt/j7DrPhDjzt3lIkDpy5FB99c9fIAa+ qvXM3/iZoVMPXtTqrlqkF+c4i12/MWHi2ZZjdonxFH6VCQ4JMmLSDxejLcHYgyldshWi 4qBJtlFbkd4jrm1pgWtkY0LpBgAhZ28ii20tNt/DihD21w4uFcml6YHiZlA7xzTgmXzy URSW54/hnmZzT8sq/avp1oSmMpV6Q4yhVyXnWcTqaOXW672daQ111oJ+Bm09DKrGTuTQ MGDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si59868737pfi.240.2019.08.09.12.01.15; Fri, 09 Aug 2019 12:01:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406558AbfHITAm (ORCPT + 99 others); Fri, 9 Aug 2019 15:00:42 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:55398 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726358AbfHITAl (ORCPT ); Fri, 9 Aug 2019 15:00:41 -0400 Received: (qmail 5162 invoked by uid 2102); 9 Aug 2019 15:00:40 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 9 Aug 2019 15:00:40 -0400 Date: Fri, 9 Aug 2019 15:00:40 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Prashant Malani cc: syzbot , , , , , , Subject: Re: KASAN: use-after-free Read in usb_kill_urb In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Aug 2019, Prashant Malani wrote: > Hi, > > I'm trying to get up to speed on USB kernel code. Sounds like > dev->intf should have been set to NULL for the error path in > ld_usb_probe() ? Why should it? After all, dev gets deallocated at the end of ld_usb_probe(), where ld_usb_delete() is called. Who cares what value is stored in deallocated memory? Alan Stern