Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp758841ybl; Fri, 9 Aug 2019 13:28:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzQfYCTPsxo7IVnUfyHxafSBImyiZiA1qqqHkUrhFPowSBgau7Df3zF4LZqlCluRITj+1ml X-Received: by 2002:a17:902:830c:: with SMTP id bd12mr21115859plb.237.1565382506250; Fri, 09 Aug 2019 13:28:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565382506; cv=none; d=google.com; s=arc-20160816; b=GTz59Rgp5bdi4/tYXTB//E2wPVSLJi+mZIZ2ER6J2bN7O/COl+HufS6V3uHmj+u/q0 yamzL7DjyzNMbyEgjpdM/WtRq54/mqEQ7gwdYJOYUf0XWHyMVgRoyBYpra6cHTs5UaFf xE8oQIcpcwWbjcyYH+RSh2H9qL5bb/rN8IP0zM9nwCpVtmUspmL4o4GdelHNhIhB9kaq +CM838KGmFw/vf/nmV7IzR2mJCQ96ItVRVtGQ5KE/684/3IR+fxaz8tt6Bwjt1OP4P9V +FAgY4TbQZIB73e/rE4G8UyrOLKkrnVojwLhsVfFV+EC1VqBjLo1hbH/hGtV4Vr+Zw4f LX3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=o2d4QWhw4Uk2L7QvDmAqwOQHBdtU+aYcyU4/pNV+AAU=; b=qCfj9khy1H6cIWvUttFjKHyPQ/6W29imuLABDIwFKqirTbQRREfM5rdGOlQsMbnirb 7IyAr9Le+y4AZDTHOFi4FUplip8N+yUFyp0g6iTsj1g8KLsJv4nJzECwX28Tb8K6bx8l eWbmdm1MY8AKl2nnuwiQXrc85uCtBWBdU08AiY0f7SOyiG6PHp/coWtBtcUOYvvIYuVr W5H1CczyjZ9vqYhIiZLf2n/6efZ2y9cdynMPIjCaFm+hgmoO9iiQivM2VGIlpEM4quLE s25ZcORmRKqr/7AMC7kd8VtDz6+IMxoqK5X3+TmNvQFY4QBXie2uFuNKVOV3bE1GBs3L XeTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=vXxLrrrz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si50989226plm.295.2019.08.09.13.28.11; Fri, 09 Aug 2019 13:28:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=vXxLrrrz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfHIUZq (ORCPT + 99 others); Fri, 9 Aug 2019 16:25:46 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:54404 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfHIUZp (ORCPT ); Fri, 9 Aug 2019 16:25:45 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x79KPd7C066866; Fri, 9 Aug 2019 15:25:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1565382339; bh=o2d4QWhw4Uk2L7QvDmAqwOQHBdtU+aYcyU4/pNV+AAU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vXxLrrrz5Xh8rhhiZyQYlhILQPEfu1bHh4v4z1XSeLZ6jYWBmDsbtiKcHRsgIDvUc ESw6uWXtRfAknamoZJ2K+8ZutfRSvaL+uHj3Wy7cXhkzibTGV5Fl3nWFeAHpFN9dKx Z81cy3ihT34YDa4szazuDPKcQjaDao6m7qzrjudo= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x79KPdOK081000 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 9 Aug 2019 15:25:39 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 9 Aug 2019 15:25:38 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Aug 2019 15:25:38 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x79KPcqc121268; Fri, 9 Aug 2019 15:25:38 -0500 Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK" To: Bjorn Andersson CC: , Loic Pallardy , , References: <20181024011909.21674-1-s-anna@ti.com> From: Suman Anna Message-ID: <40831f80-1e36-66ca-b8e5-684d46ba167e@ti.com> Date: Fri, 9 Aug 2019 15:25:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20181024011909.21674-1-s-anna@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 10/23/18 8:19 PM, Suman Anna wrote: > The virtio_rpmsg_bus driver uses the "%p" format-specifier for > printing the vring buffer address. This prints only a hashed > pointer even for previliged users. Use "%pK" instead so that > the address can be printed during debug using kptr_restrict > sysctl. Seems to have been lost among the patches, can you pick up this trivial patch for 5.4? Should apply cleanly on the latest HEAD as well. regards Suman > > Signed-off-by: Suman Anna > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index f29dee731026..1345f373a1a0 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -950,7 +950,7 @@ static int rpmsg_probe(struct virtio_device *vdev) > goto vqs_del; > } > > - dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", > + dev_dbg(&vdev->dev, "buffers: va %pK, dma %pad\n", > bufs_va, &vrp->bufs_dma); > > /* half of the buffers is dedicated for RX */ >