Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750806AbVLMRhk (ORCPT ); Tue, 13 Dec 2005 12:37:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751090AbVLMRhk (ORCPT ); Tue, 13 Dec 2005 12:37:40 -0500 Received: from omx1-ext.sgi.com ([192.48.179.11]:2280 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1750806AbVLMRhk (ORCPT ); Tue, 13 Dec 2005 12:37:40 -0500 Date: Tue, 13 Dec 2005 09:37:11 -0800 (PST) From: Christoph Lameter To: Paul Jackson cc: Andrew Morton , dada1@cosmosbay.com, linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au, Simon.Derr@bull.net, ak@suse.de Subject: Re: [PATCH] Cpuset: rcu optimization of page alloc hook In-Reply-To: <20051213075345.c39f335d.pj@sgi.com> Message-ID: References: <20051211233130.18000.2748.sendpatchset@jackhammer.engr.sgi.com> <439D39A8.1020806@cosmosbay.com> <20051212020211.1394bc17.pj@sgi.com> <20051212021247.388385da.akpm@osdl.org> <20051213075345.c39f335d.pj@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 19 On Tue, 13 Dec 2005, Paul Jackson wrote: > So my intuition is: > If read alot but seldom written, mark "__read_mostly". > If seldom read or written, leave unmarked. Correct. > 1) I would -not- mark "struct kmem_cache *cpuset" __read_mostly, as it > is rarely accessed on -any- code path, much less a hot one. It is > ideal cannon fodder. Agree. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/