Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp841838ybl; Fri, 9 Aug 2019 14:55:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbH2QwhmoA9Z3JaaHTtGP+m7Bgjws3URXSsD55oKlAhQZaga+LgVDUu3JwobvuDj1Y2EmP X-Received: by 2002:a17:90a:c70c:: with SMTP id o12mr11690390pjt.62.1565387713050; Fri, 09 Aug 2019 14:55:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565387713; cv=none; d=google.com; s=arc-20160816; b=fVOzb/ROXOF2SAjmKvMuLdtkngYqzwlJvECNfXaivKWnPeaJanW+KztOP1JLFuCM3q gH6hDXGH54iDe4NSY8jij92ZG4zG39KoBZjTz5bPwiCPvnecLxHBeN5DQMB5PoR+6r4P aB1ylZ1W3Sbl/ABzTFuIktkS3ZX7wzZ6P3/q2vU5vD+A76KvqxMmfrEVTGRcTDppHN1E a1tAc48XB5lTrhpMMLAxabCF2PZCCqxDVzZQ9w76RcZB7bhT4RdbxbyKKGpODUfLPhvC MwnaIjG4ZUcF8YGFOi4n0gkuQoCasiMg5xtMiOv/BfDVhkkzGaN9WaZQgFvoxkmQVL2C CwQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=ukb1Zqvwt96yrIxgQQEQnGVIiIApqgSGRVfi7T0+Jj0=; b=eBHLAD2gTbdImQi9JrF7FBXCoYO4q5Ehar7ieEJ/E6yn5fucUY9OmQbGd5Gxuko+6x B63xRpXNkZMP+6OLrMEauUMnMeJqbLk/iqDnq8iouaTAkJ81Rfc8WejHAP05MoPbuxOM Pz3w1TeC13uq6j51z5manok0fWlbAT9mc5uSdkT5s6SoWeLgxMa7VS86xpBR4P6lxjTo TwePj87WibyIxsB0j/jj/NO6i+GAk7zf4aV8n3x4as7EfgWgs8lORZ4Vocvdd1WLidf1 akBdUNoVcM2/y+LYvrmDaMe0u9Y6twipFX4etOnOOmtWcPVgQIzBxYTvm0Bw6K+XOBqE IBsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=sI2djgBN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si58236868pgs.458.2019.08.09.14.54.57; Fri, 09 Aug 2019 14:55:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=sI2djgBN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfHIVyY (ORCPT + 99 others); Fri, 9 Aug 2019 17:54:24 -0400 Received: from mail-yw1-f73.google.com ([209.85.161.73]:53499 "EHLO mail-yw1-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfHIVyX (ORCPT ); Fri, 9 Aug 2019 17:54:23 -0400 Received: by mail-yw1-f73.google.com with SMTP id e7so8332788ywh.20 for ; Fri, 09 Aug 2019 14:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=ukb1Zqvwt96yrIxgQQEQnGVIiIApqgSGRVfi7T0+Jj0=; b=sI2djgBN6cPLMgwD0FGqCodfYe+k2IT9TjQoBlBsI49JY2viIrggDlcrgzYYHGjYuv dCplPLLlGoc6MiW0IJTBaJAZeST6XSCpDG7qNXVZZRWJvQ+XtzHk52/rz5t4m+1OTv8t Tolwd/s7AKIq2Ucg6/SJKB7WCo7YkZitZmj0kJ4bZd2c3bqW5Du2NiZVP0iyeMlT3V/t Tx6xw8eA4zePcqFZR8w9RWGk9EJLi8uvO8XtK0h9VLVjLcUoWPy1sER4J3gpNnAkyiFM VZYsCzHop1nGaWVd8OoRtnojc7C87FmqalWjuDGlVLyspZgF8GgYnQwhLBFt3/phdJ9d pgbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=ukb1Zqvwt96yrIxgQQEQnGVIiIApqgSGRVfi7T0+Jj0=; b=dFeHx1vXE6qJTu6zlGHE15ITG2QLdHeZQ1QapsNQQm6egUEffmhkJi2OT0o9xHOtXY AprDdY70pHOUKUxgWc/204geadf/QZi3BAo75G5pi5H5jJG2fCMW3C7v1oIKEF4jDY2c HsQbI5lfkd78eWRzGmFjPhFgeToNYRYkZN9eL5wDpKElWmmed5AlQi0fz8NXJhf1DjhX cUJBq2oc3yeqx2e2PyG7aSAj/vxozkeIMG7ls3akTe5qhWJTndeKzlMvpUag2j2Fh3iL EzH7zKP34436ByCFS7LhLA7SSnN14QxFt/JRDDXjuTperq/fpsFUU9JFOVXCuSSPdzMr oRUg== X-Gm-Message-State: APjAAAV6hX605snvon/ndo/AxRWnbOksH47lkJHsbZQdZ9BBmG79X+ry bMD0XBbt0sJ2m6PgOnBUWUasnOinUw== X-Received: by 2002:a25:6302:: with SMTP id x2mr16178910ybb.6.1565387662988; Fri, 09 Aug 2019 14:54:22 -0700 (PDT) Date: Fri, 9 Aug 2019 14:54:20 -0700 In-Reply-To: Message-Id: <20190809215420.41874-1-yabinc@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: From: Yabin Cui To: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yabin Cui Subject: Re: [PATCH] coresight: Serialize enabling/disabling a link device. >You may also want to protect the refcount checks below with the same lock, just >to be consistent. Good suggestion! I didn't protect it because I found other places using refcnt. But it turns out they are not link devices. I have uploaded patch v2.