Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp847895ybl; Fri, 9 Aug 2019 15:01:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxt+15WI9KnSkzK4Ziv1ec875WPoC14FX4lewwHq3x/SF+b5m7y0XaHPwriDo8nTglBMNfX X-Received: by 2002:a65:430a:: with SMTP id j10mr19973380pgq.374.1565388098903; Fri, 09 Aug 2019 15:01:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565388098; cv=none; d=google.com; s=arc-20160816; b=pPFkG0ODV3wHQjoG4jbd2u0ZltA3OLT42pcQ29NCSx+X953QlJIAaZFoSnsXcqtTcX 2x4xiaq9Zfxj5rVpdg2uSRzsKpqgUYisAgTiucN8x1bofqEOccwTJTfxAu7aqJiyiPmN S4nq9Lz5y9kvpZt9DNsiBuJvNn13a2PilbSI0++oTBTLkhiYiteKvewVKihGgnUy1dmc A6tK2GZJv9W/G18Mgh9/7cmDHZukpSC8oFZTO4xiIN+lHojNa8Rl5puTLPkaHer2jvoZ d13y5vspRlKFIvNDxrgjOLsb9DliYyhpsub7fCkUKH9qW0PKnqqJ2F7wj2dCFPBKKtm5 iIvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=Y4kaateCHJ+fJurjLY96H4/yGh3d1HRHmZDQTp9gvFGZpg4r76aTxgjD/UKrwumIeo KiArXRDrgQIkog/1sDxQ/8qR3aQJszj3nyMj0wVQzPnPMyo+3f61t44k0unkgM21AHoj AC97ofLYrmEL4O7j8CTkz+adOPKoSkkIMLx+nZHIKw+AJFQd7VDvar57SjzYjMBo1vW4 e3THpQutgHqCTyy7o2f2KetK8/uhzY6jC3X67FO6LcjTV+KWIh53y1F/YBpMiERnhTdv E2dRiMkFZZOnwLKu3ZgYd31Gb5p1iNAvW4lFl22vzD9xJT177pIjnmyI1U0un8KY9dW3 6/CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XmhQBsfM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si52789650pgc.29.2019.08.09.15.01.23; Fri, 09 Aug 2019 15:01:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XmhQBsfM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbfHIV7R (ORCPT + 99 others); Fri, 9 Aug 2019 17:59:17 -0400 Received: from mail-pf1-f202.google.com ([209.85.210.202]:49044 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfHIV7Q (ORCPT ); Fri, 9 Aug 2019 17:59:16 -0400 Received: by mail-pf1-f202.google.com with SMTP id u21so62302320pfn.15 for ; Fri, 09 Aug 2019 14:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=XmhQBsfMHALmx6QOLM9UBumnO7+O8bCcXOWfbEhvnKPRZtyZjK8Tox3QlWh+5SsoHo nSFWQ4AXRB5rGt1kt3KE4aQEc1I3c3lRuL9npZ/+GiDm5vL+RU7MnPYmUFcMbJyKb6ra WcTRcRm2FQ6DDaHqNyLsrOSB632i+21o8ygllWidqV7vliACQwXLx06D5cWErjUfEvvk oS6tlLYGXRIUWgi8FZPNnxObKBs0OQf/b3sPOwVn84irLt21e12rwexZf1dIbzAlT4UU pC9A8HRAZ1JoHP5xAxw+zFJ7gBhI3E9LOkogGnAloitRhXpmiawVE738kNJQ2UpHPLsi ecbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=M2Rqlf+ufzTybVB8TVyBZN3JsbUXmQr16MuQyGUgBgynKDzw9iP2SOr0UDkN9OgO0k agG301iawaRbtGNzKyfQ0d5YBAByyjeD1n4HsINOvhiTiNAOozu62sJ64Fyjpq0Q9gNN eSEZy8iSfLD/XIWCXV9Uu4EuJC+tolAF7LfDE5MetxwlPiN9k+nXxywmVxhmX6pQ1W1Z AAN1+RNGmgmuchcNDq9SxFJkWdmSl4heWNCUKHgaHHvPWNTy5isqmu9HCahNI1zlZaA5 ZWxqrxRsAm3gPIx6Z25WuD6ynFWydKFsOpxIPovFHec9FmDcupkNR6p/OhjNetVHs+x2 VBvw== X-Gm-Message-State: APjAAAV0C6B/0lhsDmi5yGpLWwpSv2q/V7uiZKPtjen0XIuddWoYnbhF B8zLXNK77eo5oT5ruAV/mtDvNpZNeA== X-Received: by 2002:a63:bf01:: with SMTP id v1mr18841445pgf.278.1565387955717; Fri, 09 Aug 2019 14:59:15 -0700 (PDT) Date: Fri, 9 Aug 2019 14:58:48 -0700 In-Reply-To: Message-Id: <20190809215848.47736-1-yabinc@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: Re: [PATCH] coresight: Serialize enabling/disabling a link device. From: Yabin Cui To: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yabin Cui Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >You may also want to protect the refcount checks below with the same lock, just >to be consistent. Good suggestion! I didn't protect it because I found other places using refcnt. But it turns out they are not link devices. I have uploaded patch v2.