Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: RIP: e030:bfq_exit_icq_bfqq+0x147/0x1c0
To:     Paolo Valente <paolo.valente@linaro.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Douglas Anderson <dianders@chromium.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <6cfd07de-f5a8-78ea-405a-0243061cb620@eikelenboom.it>
 <6A27F793-838B-4329-8C26-8768ED9BBD8A@linaro.org>
 <1d2e8bf8-902e-3e3c-ce0f-78efedf82209@eikelenboom.it>
 <E34CECED-072D-449D-91F1-2ECF8DF53612@linaro.org>
From:   Sander Eikelenboom <linux@eikelenboom.it>
Message-ID: <1385e95d-26a6-888f-3e34-de4d4112a160@eikelenboom.it>
Date:   Sat, 10 Aug 2019 00:15:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <E34CECED-072D-449D-91F1-2ECF8DF53612@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/08/2019 12:21, Paolo Valente wrote:
> 
> 
>> Il giorno 8 ago 2019, alle ore 12:21, Sander Eikelenboom <linux@eikelenboom.it> ha scritto:
>>
>> On 08/08/2019 11:10, Paolo Valente wrote:
>>>
>>>
>>>> Il giorno 8 ago 2019, alle ore 11:05, Sander Eikelenboom <linux@eikelenboom.it> ha scritto:
>>>>
>>>> L.S.,
>>>>
>>>> While testing a linux 5.3-rc3 kernel on my Xen server I come across the splat below when trying to shutdown all the VM's.
>>>> This is after the server has ran for a few days without any problem. It seems to happen consistently.
>>>>
>>>> It seems it's in the same area as dbc3117d4ca9e17819ac73501e914b8422686750, but already rc3 incorporates that patch.
>>>>
>>>> Any ideas ?
>>>>
>>>
>>> Could you try these fixes I proposed yesterday:
>>> https://lkml.org/lkml/2019/8/7/536
>>> or, on patchwork:
>>> https://patchwork.kernel.org/patch/11082247/
>>> https://patchwork.kernel.org/patch/11082249/
>>
>> Hi Paolo,
>>
>> These two above seem to fix the issue !
>> So thanks for the swift reply (and the patchwork links for easy
>> downloading the patches).
>>
>> I will test the third unrelated patch as well, but if you don't hear
>> back , it's all good.
>>
> 
> Great! Thank you for offering to test also the other patch. Tested-by are welcome too :)

Hi,

Haven't seen any problems with the patch so far, but haven't tested it
on constraint memory, so i don't think a tested-by is justified in this
case.

--
Sander

> Thanks,
> Paolo
> 
>> Thanks again !
>>
>> --
>> Sander
>>
>>> I posted a further fix too, which should be unrelated. But, just in case:
>>> https://lkml.org/lkml/2019/8/7/715
>>> or, on patchwork:
>>> https://patchwork.kernel.org/patch/11082521/
>>>
>>> Crossing my fingers (and think you for reporting this),
>>> Paolo
>>>
>>>> --
>>>> Sander
>>>>
>>>>
>>>> [80915.716048] BUG: unable to handle page fault for address: 0000100000000008
>>>> [80915.724188] #PF: supervisor write access in kernel mode
>>>> [80915.733182] #PF: error_code(0x0002) - not-present page
>>>> [80915.741455] PGD 0 P4D 0 
>>>> [80915.750538] Oops: 0002 [#1] SMP NOPTI
>>>> [80915.758425] CPU: 4 PID: 11407 Comm: 17.hda-2 Tainted: G        W         5.3.0-rc3-20190807-doflr+ #1
>>>> [80915.766137] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640)  , BIOS V1.8B1 09/13/2010
>>>> [80915.773737] RIP: e030:bfq_exit_icq_bfqq+0x147/0x1c0
>>>> [80915.781294] Code: 00 00 00 00 00 00 48 0f ba b0 20 01 00 00 0c 48 8b 88 f0 01 00 00 48 85 c9 74 29 48 8b b0 e8 01 00 00 48 89 31 48 85 f6 74 04 <48> 89 4e 08 48 c7 80 e8 01 00 00 00 00 00 00 48 c7 80 f0 01 00 00
>>>> [80915.796792] RSP: e02b:ffffc9000473be28 EFLAGS: 00010006
>>>> [80915.804419] RAX: ffff888070393200 RBX: ffff888076c4a800 RCX: ffff888076c4a9f8
>>>> [80915.810254] device vif17.0 left promiscuous mode
>>>> [80915.811906] RDX: 0000100000000000 RSI: 0000100000000000 RDI: 0000000000000000
>>>> [80915.811908] RBP: ffff888077efc398 R08: 0000000000000004 R09: ffffffff81106800
>>>> [80915.811909] R10: ffff88807804ca40 R11: ffffc9000473be31 R12: ffff888005256bf0
>>>> [80915.811909] R13: 0000000000000000 R14: ffff888005256800 R15: ffffffff82a6a3c0
>>>> [80915.811919] FS:  00007f1c30a8dbc0(0000) GS:ffff88807d500000(0000) knlGS:0000000000000000
>>>> [80915.819456] xen_bridge: port 18(vif17.0) entered disabled state
>>>> [80915.826569] CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>>>> [80915.826571] CR2: 0000100000000008 CR3: 000000005d9d0000 CR4: 0000000000000660
>>>> [80915.826575] Call Trace:
>>>> [80915.826592]  bfq_exit_icq+0xe/0x20
>>>> [80915.826595]  put_io_context_active+0x52/0x80
>>>> [80915.826599]  do_exit+0x774/0xac0
>>>> [80915.906037]  ? xen_blkif_be_int+0x30/0x30
>>>> [80915.913311]  kthread+0xda/0x130
>>>> [80915.920398]  ? kthread_park+0x80/0x80
>>>> [80915.927524]  ret_from_fork+0x22/0x40
>>>> [80915.934512] Modules linked in:
>>>> [80915.941412] CR2: 0000100000000008
>>>> [80915.948221] ---[ end trace 61315493e0f8ef40 ]---
>>>> [80915.954984] RIP: e030:bfq_exit_icq_bfqq+0x147/0x1c0
>>>> [80915.961850] Code: 00 00 00 00 00 00 48 0f ba b0 20 01 00 00 0c 48 8b 88 f0 01 00 00 48 85 c9 74 29 48 8b b0 e8 01 00 00 48 89 31 48 85 f6 74 04 <48> 89 4e 08 48 c7 80 e8 01 00 00 00 00 00 00 48 c7 80 f0 01 00 00
>>>> [80915.976124] RSP: e02b:ffffc9000473be28 EFLAGS: 00010006
>>>> [80915.983205] RAX: ffff888070393200 RBX: ffff888076c4a800 RCX: ffff888076c4a9f8
>>>> [80915.990321] RDX: 0000100000000000 RSI: 0000100000000000 RDI: 0000000000000000
>>>> [80915.997319] RBP: ffff888077efc398 R08: 0000000000000004 R09: ffffffff81106800
>>>> [80916.004427] R10: ffff88807804ca40 R11: ffffc9000473be31 R12: ffff888005256bf0
>>>> [80916.011525] R13: 0000000000000000 R14: ffff888005256800 R15: ffffffff82a6a3c0
>>>> [80916.018679] FS:  00007f1c30a8dbc0(0000) GS:ffff88807d500000(0000) knlGS:0000000000000000
>>>> [80916.025897] CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>>>> [80916.033116] CR2: 0000100000000008 CR3: 000000005d9d0000 CR4: 0000000000000660
>>>> [80916.040348] Fixing recursive fault but reboot is needed!
>