Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jon Maloy <jon.maloy@ericsson.com>
To:     Chris Packham <chris.packham@alliedtelesis.co.nz>,
        "ying.xue@windriver.com" <ying.xue@windriver.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] tipc: initialise addr_trail_end when setting node
 addresses
Thread-Topic: [PATCH v2] tipc: initialise addr_trail_end when setting node
 addresses
Thread-Index: AQHVTk0Yw1fWCdXpz0COXP7OMd9Hsab0omhQ
Date:   Sat, 10 Aug 2019 17:46:48 +0000
Message-ID: <CH2PR15MB35751C0AA17673A100E646839AD10@CH2PR15MB3575.namprd15.prod.outlook.com>
References: <20190809005451.18881-1-chris.packham@alliedtelesis.co.nz>
In-Reply-To: <20190809005451.18881-1-chris.packham@alliedtelesis.co.nz>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: ericsson.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e19fb9-16d1-4743-7650-08d71dbab877
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2019 17:46:49.0005
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1MwiKXivKbTHgHJH5GO1962x5g8Bdy+QGONJzFVbttRXM2eIqUADvNoEdfATDoRCCyGWdzUwiwxNaJA6EYfjYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR15MB3637
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I would re-phrase this a little:
We set the field 'addr_trial_end' to 'jiffies', instead of the current valu=
e 0,  at the moment the node address is initialized.=20
This guarantees we don't inadvertently enter an address trial period when t=
he node address is explicitly set by the user.

Acked-by: Jon Maloy <jon.maloy@ericsson.com>


> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Chris Packham
> Sent: 8-Aug-19 20:55
> To: Jon Maloy <jon.maloy@ericsson.com>; ying.xue@windriver.com;
> davem@davemloft.net
> Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-
> kernel@vger.kernel.org; Chris Packham <chris.packham@alliedtelesis.co.nz>
> Subject: [PATCH v2] tipc: initialise addr_trail_end when setting node add=
resses
>=20
> Ensure addr_trail_end is set to jiffies when configuring the node address=
. This
> ensures that we don't treat the initial value of 0 as being a wrapped. Th=
is isn't a
> problem when using auto-generated node addresses because the
> addr_trail_end is updated for the duplicate address detection phase.
>=20
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Changes in v2:
> - move setting to tipc_set_node_addr() as suggested
> - reword commit message
>=20
>  net/tipc/addr.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/net/tipc/addr.c b/net/tipc/addr.c index
> b88d48d00913..0f1eaed1bd1b 100644
> --- a/net/tipc/addr.c
> +++ b/net/tipc/addr.c
> @@ -75,6 +75,7 @@ void tipc_set_node_addr(struct net *net, u32 addr)
>  		tipc_set_node_id(net, node_id);
>  	}
>  	tn->trial_addr =3D addr;
> +	tn->addr_trial_end =3D jiffies;
>  	pr_info("32-bit node address hash set to %x\n", addr);  }
>=20
> --
> 2.22.0