Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190711012915.5581-1-yuchao0@huawei.com>
In-Reply-To: <20190711012915.5581-1-yuchao0@huawei.com>
From:   Ju Hyung Park <qkrwngud825@gmail.com>
Date:   Sun, 11 Aug 2019 04:53:37 +0900
Message-ID: <CAD14+f3fiY8m7f91-ohHUj8ThMeYF7+Q=DU8c2c_8PTis8t-mw@mail.gmail.com>
Subject: Re: [PATCH v2] f2fs: improve print log in f2fs_sanity_check_ckpt()
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jaegeuk,

I think we'll all appreciate if v1.13.0 gets tagged :)
I believe the current dev branch has been in good shape for quite some time=
 now.

Thanks.


2019=EB=85=84 7=EC=9B=94 11=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 10:31, =
Chao Yu <yuchao0@huawei.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> As Park Ju Hyung suggested:
>
> "I'd like to suggest to write down an actual version of f2fs-tools
> here as we've seen older versions of fsck doing even more damage
> and the users might not have the latest f2fs-tools installed."
>
> This patch give a more detailed info of how we fix such corruption
> to user to avoid damageable repair with low version fsck.
>
> Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> v2:
> - add fixing patch's title in log suggested by Jaegeuk.
>  fs/f2fs/super.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 1a6d82d558e4..47dae7c3ae4f 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2696,7 +2696,9 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi=
)
>
>         if (__is_set_ckpt_flags(ckpt, CP_LARGE_NAT_BITMAP_FLAG) &&
>                 le32_to_cpu(ckpt->checksum_offset) !=3D CP_MIN_CHKSUM_OFF=
SET) {
> -               f2fs_warn(sbi, "layout of large_nat_bitmap is deprecated,=
 run fsck to repair, chksum_offset: %u",
> +               f2fs_warn(sbi, "using deprecated layout of large_nat_bitm=
ap, "
> +                         "please run fsck v1.13.0 or higher to repair, c=
hksum_offset: %u, "
> +                         "fixed with patch: \"f2fs-tools: relocate chksu=
m_offset for large_nat_bitmap feature\"",
>                           le32_to_cpu(ckpt->checksum_offset));
>                 return 1;
>         }
> --
> 2.18.0.rc1
>