Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out of
 staging
Thread-Topic: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out
 of staging
Thread-Index: AQHVTsse6Qsm2zNpN0akGPBvGQTj7Q==
Date:   Sun, 11 Aug 2019 21:20:05 +0000
Message-ID: <VI1PR0402MB2800292DCA9CC91085E5033FE0D00@VI1PR0402MB2800.eurprd04.prod.outlook.com>
References: <1565366213-20063-1-git-send-email-ioana.ciornei@nxp.com>
 <20190809190459.GW27917@lunn.ch>
 <VI1PR0402MB2800FF2E5C4DE24B25E7D843E0D10@VI1PR0402MB2800.eurprd04.prod.outlook.com>
 <20190811032235.GK30120@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f3125374-b1b6-4711-3d22-08d71ea1ae7e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2019 21:20:06.0472
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ixEdxVUB+hdLqwUbeYBU7ULZhzRUxEv1cZ70RT7XSYY3a34GJLjKhg4a3kZbmC3lbd059ZBC/qr+PcxJH9Nehg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2846
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/11/19 6:22 AM, Andrew Lunn wrote:=0A=
> Hi Ioana=0A=
> =0A=
>>   >> +	struct ethsw_port_priv *port_priv =3D netdev_priv(netdev);=0A=
>>   >> +	struct ethsw_core *ethsw =3D port_priv->ethsw_data;=0A=
>>   >> +	int i, err;=0A=
>>   >> +=0A=
>>   >> +	for (i =3D 0; i < ethsw->sw_attr.num_ifs; i++)=0A=
>>   >> +		if (ethsw->ports[i]->bridge_dev &&=0A=
>>   >> +		    (ethsw->ports[i]->bridge_dev !=3D upper_dev)) {=0A=
>>   >> +			netdev_err(netdev,=0A=
>>   >> +				   "Another switch port is connected to %s\n",=0A=
>>   >> +				   ethsw->ports[i]->bridge_dev->name);=0A=
>>   >> +			return -EINVAL;=0A=
>>   >> +		}=0A=
>>   >=0A=
>>   > Am i reading this correct? You only support a single bridge?  The=0A=
>>   > error message is not very informative. Also, i think you should be=
=0A=
>>   > returning EOPNOTSUPP, indicating the offload is not possible. Linux=
=0A=
>>   > will then do it in software. If it could actually receive/transmit t=
he=0A=
>>   > frames....=0A=
>>   >=0A=
>>=0A=
>> Yes, we only support a single bridge.=0A=
> =0A=
> That is a pretty severe restriction for a device of this class. Some=0A=
> of the very simple switches DSA support have a similar restriction,=0A=
> but in general, most do support multiple bridges.=0A=
> =0A=
=0A=
Let me make a distinction here: we do no support multiple bridges on the =
=0A=
same DPSW object but we do support multiple DPSW objects, each with its =0A=
bridge.=0A=
=0A=
=0A=
> Are there any plans to fix this?=0A=
> =0A=
=0A=
We had some internal discussions on this, the hardware could support =0A=
this kind of further partitioning the switch object but, at the moment, =0A=
the firmware doesn't.=0A=
=0A=
> Thanks=0A=
> 	Andrew=0A=
> =0A=