Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3235187ybl; Sun, 11 Aug 2019 18:51:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0mHc44+4RLBybiwW8uvHloZwZUxw6bVSzV9WNfunZxDoekLTPKznUTtTva7crC3Epl2cA X-Received: by 2002:a17:90a:d998:: with SMTP id d24mr21044304pjv.89.1565574716879; Sun, 11 Aug 2019 18:51:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565574716; cv=none; d=google.com; s=arc-20160816; b=kOPqDfMmPiNMhpZPtKsa2syAvLbMi2d12QgfgTog/8y6aT73wmXX7N1vOyDORhKl5o h5NONUB4+8w0MyANKlbP6vQmp9oSt4z0jnGMEgYu2A+HQUMqiDBZRKyvw75mIlYK9YRw zgNfopOIVi3a8BCwqfwcBqTuH5+twcBUwxv8uhUsQKwMbuIPG7X1OT+sjLTTiE5emvYl SW9dtseyiHgCeBe6AFV75Ozo6iEzAHzp4gyvrgmmT0U4axbm9K1pkznaCDdYnLbXbrPJ Wda/PJIUt1/OkWuX9h5XWZDpvCw0GPFzZY7Ir893IlNguAxQ0TXNHGy6B7VIpSKdrXJR JTDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=//FfBrFJF4GgHRR+yYGohW47iWmsEIpsgR4o2CfLEaI=; b=mp3xDZthvdobWPvd+2IcRfPnKHGtX2/37VTKf9eA4GZvrkRD+zD999Rqi6jJSt1gfi 0EuZFagbfQW7FvxPtMahZhFO/CpauPaAlxHw9T1BB3q+cSORy2Zue0QnwDXT1RjtOS7n zbwmyZ4PGN3C2gdBEXlcXiZmX65k3ReWT59A2DCmrA51N7Fga7sRy3avYTAiK7zdXEUX xxlCcBOkT3QXSuIabUChi8MwszlUc4vwxzm0t9F+it4HdAu4cnYz+1YIFhvGNBj1E12J 4lDDwYoZzP1eStnac0vmRDPN0IA+EH/sAA2Kw7EVVd6PEgJ32P4af5sCT2P9vdldwbxf 38Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n9WdsBYC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s128si62919667pfb.207.2019.08.11.18.51.39; Sun, 11 Aug 2019 18:51:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n9WdsBYC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfHLBvA (ORCPT + 99 others); Sun, 11 Aug 2019 21:51:00 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36191 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfHLBu5 (ORCPT ); Sun, 11 Aug 2019 21:50:57 -0400 Received: by mail-pl1-f195.google.com with SMTP id g4so785412plo.3; Sun, 11 Aug 2019 18:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=//FfBrFJF4GgHRR+yYGohW47iWmsEIpsgR4o2CfLEaI=; b=n9WdsBYCNshNyrjNwoA988ZTa5cUmZ3ftfo2srk4qVaeFk/3QoLLi5AAHL4AElSmiI XuhzXcej3mP/qZgB3XHsGbTfB/yNKw6cCUUIAPQ+5Nz8QE6P37CaiJAF1juYEdwzcQ7x KCBBLQdzMFyQAH/huuHEICl517WeOf9evlQYRM6ra2qmGObt90NYEQrc2g3Hrh2Z96nu KDGoR5r30ngur4PCtV8FhCZSZwFtTuDq2bAvEGOaEF6xs7+I2IMBDgXvMsOlYXQ02UbB 3XrvtA2d2QJxWudzhOEkOmMrqZS8v6TJDdTbi1eDdq4ek8o80TJA5b2A6NTjpOCVITJa 5I0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=//FfBrFJF4GgHRR+yYGohW47iWmsEIpsgR4o2CfLEaI=; b=s1Tqi5Ho9l68qUnJg2DpDM3hCfFgcjt+i4BWmpcWAcbwnXmk0SrjKXI2sYWQLPbR3k Z9Sdw14Zknfcw8zi/tExms3m4rxzuqw7CKOePEzaFhP9Yc5zf3Q6AlL6mWh1YiciSGHe 0hDpP8McVlJuP0+cFMnEMLtY640SHJJn0iIba0IFsVvjaGuYQik887A3IbK8yiFn3rj7 0xADGp+v0kVBoarO6LxZLpkxcPrb3/FgHz8eCfPBIM9f+XJYRI53hoJhoI+BDMP/g8K2 WMEdqZC+s6hpnQ5+S8ZtofKJ0j6wm0CLMXdWQUjo2scsE5EaNCNtcFcgSTXGXrnatl2k R2MA== X-Gm-Message-State: APjAAAXC2ep1QKmxmbbK/yDsvSMgd9r8a3w4P+b+VYQxMLxn//f6OUiH Dd3HkhNwS9+vWI61CQwAMmqKpDGv X-Received: by 2002:a17:902:b604:: with SMTP id b4mr15581107pls.94.1565574657032; Sun, 11 Aug 2019 18:50:57 -0700 (PDT) Received: from blueforge.nvidia.com (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id j20sm100062363pfr.113.2019.08.11.18.50.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 18:50:56 -0700 (PDT) From: john.hubbard@gmail.com X-Google-Original-From: jhubbard@nvidia.com To: Andrew Morton Cc: Christoph Hellwig , Dan Williams , Dave Chinner , Ira Weiny , Jan Kara , Jason Gunthorpe , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-rdma@vger.kernel.org, John Hubbard , Michal Hocko Subject: [RFC PATCH 1/2] mm/gup: introduce FOLL_PIN flag for get_user_pages() Date: Sun, 11 Aug 2019 18:50:43 -0700 Message-Id: <20190812015044.26176-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190812015044.26176-1-jhubbard@nvidia.com> References: <20190812015044.26176-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Hubbard FOLL_PIN is set by vaddr_pin_pages(). This is different than FOLL_LONGTERM, because even short term page pins need a new kind of tracking, if those pinned pages' data is going to potentially be modified. This situation is described in more detail in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). FOLL_PIN is added now, rather than waiting until there is code that takes action based on FOLL_PIN. That's because having FOLL_PIN in the code helps to highlight the differences between: a) get_user_pages(): soon to be deprecated. Used to pin pages, but without awareness of file systems that might use those pages, b) The original vaddr_pin_pages(): intended only for FOLL_LONGTERM and DAX use cases. This assumes direct IO and therefore is not applicable the most of the other callers of get_user_pages(), and c) The new vaddr_pin_pages(), which provides the correct get_user_pages() flags for all cases, by setting FOLL_PIN. Cc: Ira Weiny Cc: Jan Kara Cc: Michal Hocko Signed-off-by: John Hubbard --- include/linux/mm.h | 1 + mm/gup.c | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 90c5802866df..61b616cd9243 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2663,6 +2663,7 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address, #define FOLL_ANON 0x8000 /* don't do file mappings */ #define FOLL_LONGTERM 0x10000 /* mapping lifetime is indefinite: see below */ #define FOLL_SPLIT_PMD 0x20000 /* split huge pmd before returning */ +#define FOLL_PIN 0x40000 /* pages must be released via put_user_page() */ /* * NOTE on FOLL_LONGTERM: diff --git a/mm/gup.c b/mm/gup.c index 58f008a3c153..85f09958fbdc 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2494,6 +2494,9 @@ EXPORT_SYMBOL_GPL(get_user_pages_fast); * being made against. Usually "current->mm". * * Expects mmap_sem to be read locked. + * + * Implementation note: this sets FOLL_PIN, which means that the pages must + * ultimately be released by put_user_page(). */ long vaddr_pin_pages(unsigned long addr, unsigned long nr_pages, unsigned int gup_flags, struct page **pages, @@ -2501,7 +2504,7 @@ long vaddr_pin_pages(unsigned long addr, unsigned long nr_pages, { long ret; - gup_flags |= FOLL_LONGTERM; + gup_flags |= FOLL_LONGTERM | FOLL_PIN; if (!vaddr_pin || (!vaddr_pin->mm && !vaddr_pin->f_owner)) return -EINVAL; -- 2.22.0