Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3419535ybl; Sun, 11 Aug 2019 23:33:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwV0uCAnuFKdr3eQCslw5LIGcUZjJV8l+vkalPsmptSVn4sWRcDDzKKsBWF2JvJj1659+yR X-Received: by 2002:a17:902:20c2:: with SMTP id v2mr19206586plg.209.1565591591022; Sun, 11 Aug 2019 23:33:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565591591; cv=none; d=google.com; s=arc-20160816; b=0Yy3iFevGodg3UhRE/yUBNIB5reU9reilms5NnoJ4chFirt/ejUcrzyeT8IVCusJFo 36dQZEl3gL26+QjdmP7ykUjVlWw565aJMRkii7Txx0Q65y2xPForkQexdgBCJfyjxPNv J9AmGtf72ni4CiCcFlnba8RohaHj6jInhLK1zi+krVr/H4LFHxD8TntECOKKK+TUJpGl zDmCik7EPXXR6WfhyRsyMPvYxDlwhfJ9ilzugNrpVAploChaYq2zE91h55O0EPI5x725 ViU233CG2QxyPneWY2hrcoajbfuLzRsIQYKLMLdYGeUqeGXIA/xs+B9X+ujw6ojcq0Id ndCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MKi3BQnZIrqKiwqhUGJY8gc0723XswLwadAErFxEM8U=; b=MgvsP4TnKM+7I6fosqMjz+CYan098HLc9V/nYCsAAh5w7L4/fSXI5YTD4eMa7PAHnz HMnvcuv2Y2SIMitOw1D4/ayNOuTO7j8Dxy6s7Sr4c4TjrvD4i5rg/ZyK7a84yf+3hTzx FYNPAnl94F0gq1LxnOtL7CQ5/HUor2vZJdMAsUI1G9Xw/OHt4ebD4xok5waCcGUACq5W 0HIS8jxmyz3KzXTj1K3Fuys607Bd4LYhiecoETvVnOi9Ls87d1s2dMUdBuhF/hrJ+w3r 3i3nh1VVKeP6Qj6TuJHrfZee0kCggIyL9+Cux6JspTIci263Befu2T7E5cuKc4fCI52m X6vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v203si28402093pgb.302.2019.08.11.23.32.55; Sun, 11 Aug 2019 23:33:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726590AbfHLGcD (ORCPT + 99 others); Mon, 12 Aug 2019 02:32:03 -0400 Received: from bmailout3.hostsharing.net ([176.9.242.62]:50767 "EHLO bmailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfHLGcC (ORCPT ); Mon, 12 Aug 2019 02:32:02 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id D10B1100D9401; Mon, 12 Aug 2019 08:32:00 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 8775210D98; Mon, 12 Aug 2019 08:32:00 +0200 (CEST) Date: Mon, 12 Aug 2019 08:32:00 +0200 From: Lukas Wunner To: Denis Efremov Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] PCI: pciehp: Replace pciehp_set_attention_status() Message-ID: <20190812063200.4ngzswfvbt3gr2mx@wunner.de> References: <20190811195944.23765-1-efremov@linux.com> <20190811195944.23765-4-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811195944.23765-4-efremov@linux.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 11, 2019 at 10:59:43PM +0300, Denis Efremov wrote: > +#define pciehp_set_attention_status(ctrl, status) \ > + pciehp_set_indicators(ctrl, PWR_NONE, (status == 0 ? ATTN_OFF : status)) Reviewed-by: Lukas Wunner Good catch regarding the translation of the "off" value that's needed here.