Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3450187ybl; Mon, 12 Aug 2019 00:12:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqx14bsSeiGOdP/Ba4fRxmdyr0wMLX2qdXTW1xXzTh/Sackq+XxTtTupKhUSP0ioBRO2ow5j X-Received: by 2002:a17:90a:b011:: with SMTP id x17mr22353130pjq.113.1565593970757; Mon, 12 Aug 2019 00:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565593970; cv=none; d=google.com; s=arc-20160816; b=TiHL3qVmiT0+4YP8b75YktxS5XXDLff9kPGoqi8JjFAlEiEs4uscoxcADsgQg3qcr4 nXLoHdyXQBkDw9RXq1Fge+IRIAgGHx73vevPL68aBXLpi02vC5UEERDSfGm4t0reKQtE WOhVQuWyzJiX5bLEvop5zcbVTU49VEC93fTaNEgNdNp13qLg/vLZcTIQ8uGyAsbIKc9g lst7uujfzJ9n5RHJg6gjHQ+Ie7x9IG76UT5aSyj6/v6ZPG3bgwZtLGSiKEKyTH0bRLCC bHpwI/qG1HeBuDFLpSUcI6Njch3p8FHGnxcy0FLsQjAkK0xyeqwITEynYyGsX0Q+hYcn w/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature; bh=NZ1OizWcpbP6noxx8/xg2mgm7Hx581BOepTaovkOMgw=; b=prx4G6u9ItDX0pzjynAs8w1d4RqsdEm45rQOpLiXoh/g/08nUkAmQetpufFNrJtEVy Sm+X1VzXZmKp8ivPczf7pDmP9hOR8MvtfCvpPUUpVGdQE1I0T1zB1eqra3zDIktr4vg5 ov6PqRE5Vei0M0YqxpyygHqcH8iIQx+T4ipk+E8tAXu1GNEYzPcEmYv1e9imoaXQc05Z Lr13rPskRhfGfdExjDP5Z+YBynNO8VzagG+CezoJFQRFO5o3AJJumPHqGybJlkbm0aB2 3fq/7pldFHE72jAZQbC9z3ex/P2t0b1tee8Xr26ScvcF27PUoB6c2wsvm7uJbzWPTHlj 8wbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Yf2WF8S9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j74si10763238pje.12.2019.08.12.00.12.34; Mon, 12 Aug 2019 00:12:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Yf2WF8S9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbfHLHLw (ORCPT + 99 others); Mon, 12 Aug 2019 03:11:52 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:37091 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfHLHLw (ORCPT ); Mon, 12 Aug 2019 03:11:52 -0400 Received: by mail-lj1-f196.google.com with SMTP id z28so43148123ljn.4; Mon, 12 Aug 2019 00:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NZ1OizWcpbP6noxx8/xg2mgm7Hx581BOepTaovkOMgw=; b=Yf2WF8S9ApkFHjD4UxCouGHKiT3fooxvqPfGFdBww+sjt9fCTswOp/+dBgV7Rc+aV2 NJAzLQW8hpgJgmCfrUuCv+BQ/VQtPSg7SCm3C+tld/fSjxcjGOFx1Kpp1erKFQJgq4P4 KylSf+K35x0U+fBVxRtmGXi6a6Qj+Gly+k/CtTuoGQrnQpK++KU15mz7lTnMlxVhF2ic gKNFO1qMpZbeTX1woqJzdQ4yc63UB50yQRpfteFCY1OTWMQxPOf2sYYvXm8UOvvdgPff u6dUPEvsUHa0KUjVxbgKcEaSPvastu3RBhhbqkXfifVQbmwy49SAaTYT8GAcQ478vwOk fc0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NZ1OizWcpbP6noxx8/xg2mgm7Hx581BOepTaovkOMgw=; b=qCVe8Rk7v0+XF7Z0Gv3dmmgMpBMH/2El9iJXW22AJ6VuzivsnIqHGTfKaIXH1gQyaY yl61qeyRnl17hqG9rnMP9YixVZ25B6Gs6OTxNRowv4Thu92XZ/1Nrpa1bMz2TC8J2rjX IyJHIGStUas9/vQNSwIDYglgG0DII5FoxP25Azikg7xfqJje5+5+eub7RNmAwPakweiP wsM1xQwf/tE37vq45GTDuHdz8bggWTjR2X0FSQtC49xBM9f9etpQa8n+fM9q6K0FGDfZ OZ435A9Vr6owDjD6sZxkjpVXQy6HKR3yhbqFJm6v5yMwKSlY4hclbivBQ/YytVLXJf6Y eOgg== X-Gm-Message-State: APjAAAVLPVBiG4nSXwnHZmxvNKQSp3JNM522aZ5B+PVTlLu+zfCAd1Wb KHYnkC5dstO290U0S2uZSR4= X-Received: by 2002:a2e:9045:: with SMTP id n5mr18442876ljg.66.1565593910060; Mon, 12 Aug 2019 00:11:50 -0700 (PDT) Received: from localhost ([178.127.242.45]) by smtp.gmail.com with ESMTPSA id w4sm5327361lfk.4.2019.08.12.00.11.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 00:11:49 -0700 (PDT) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Mon, 12 Aug 2019 16:11:48 +0900 To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sedat Dilek , Hugh Dickins , Matthew Auld , Al Viro Subject: Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Message-ID: <20190812071148.GA696@tigerII.localdomain> References: <20190808172226.18306-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808172226.18306-1-chris@chris-wilson.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (08/08/19 18:22), Chris Wilson wrote: [..] > @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915) > if (!type) > return -ENODEV; [..] > + gemfs = kern_mount(type); > + if (IS_ERR(gemfs)) > + return PTR_ERR(gemfs); > > i915->mm.gemfs = gemfs; We still have to put_filesystem(). Right? -ss