Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3451786ybl; Mon, 12 Aug 2019 00:15:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBWnF977RQcfbY8Gt+0e0DDfANLos1aFDYbDQXX2vyLiKCDB9l0ac8VnrzWaJjMitImmvl X-Received: by 2002:a63:9245:: with SMTP id s5mr29643811pgn.123.1565594099469; Mon, 12 Aug 2019 00:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565594099; cv=none; d=google.com; s=arc-20160816; b=N/+ZrfMNk6mPiyR3tUWHRgayAF/dLAR/x0kcYs11cm+fhc9wuVHZGHJ+6FW0OpPKrK GpAusV7JE4Dzjh2CpMT/3dM0WMm9F+J91cZLuhnDoI7oHy2/HrhoNdYNvWBMj7cSwf6S G5iDMTI16PdFzIv5TvnGXwiC/m3GMp1UJGhs1ZR190BQ/IPAqN9926FPOBi7wnOERjQb YJ9srHbXybInbm3K+tWOIWkThLX8j5im1cC+Wl/sGtHxTpG8TBc2zSDv83yNAYah7/Mg ToF+3uzVR1LJGDEoqGMauWma80JTt7IWb8gvXO83IryaFSr4DI1j/EFdhvbtmziP0YOM cwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=tQou9L89SYf9rf2y5cgJEc+6JDARYnF8NBnFoTBtYRE=; b=sv6/gMDC2Syq2Q8f86D3+Sq2FBFvkXI8AD0Z/ij5BUHW4mnt1LrsBUOAprpTCn/8n8 Ti0z+YjyLPClmTHZE/+8x+8QPAua4QUhS9JldTVKJMgvuQiP7AaPyS1eyAPSaIIxF9Or FRcmPqEaa+dIrGfVKjdIxXBaX2Nl7Kjjdj2O/Hii5p6hYgNzzhjN6cIprHlKC4RZrYjl Rc34m2uzqh7iH8aX3/7du450TUQzQNV5oZwz/kKU2l+dXrFm6mmw/NVQN42sd5zdlvcl smwgOxSBJxH9CIY7V5wL4o9MjrSlBW4MCVqUGXAIZFzCy8fp6ub/HhZvGdobHJ+a3hyt LRvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si63634605pfi.282.2019.08.12.00.14.43; Mon, 12 Aug 2019 00:14:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbfHLHNy convert rfc822-to-8bit (ORCPT + 99 others); Mon, 12 Aug 2019 03:13:54 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:61302 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725901AbfHLHNy (ORCPT ); Mon, 12 Aug 2019 03:13:54 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 17964774-1500050 for multiple; Mon, 12 Aug 2019 08:13:28 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Sergey Senozhatsky From: Chris Wilson In-Reply-To: <20190812071148.GA696@tigerII.localdomain> Cc: intel-gfx@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sedat Dilek , Hugh Dickins , Matthew Auld , Al Viro References: <20190808172226.18306-1-chris@chris-wilson.co.uk> <20190812071148.GA696@tigerII.localdomain> Message-ID: <156559400671.2301.14424611837808765850@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Date: Mon, 12 Aug 2019 08:13:26 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sergey Senozhatsky (2019-08-12 08:11:48) > On (08/08/19 18:22), Chris Wilson wrote: > [..] > > @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915) > > if (!type) > > return -ENODEV; > [..] > > + gemfs = kern_mount(type); > > + if (IS_ERR(gemfs)) > > + return PTR_ERR(gemfs); > > > > i915->mm.gemfs = gemfs; > > We still have to put_filesystem(). Right? Yes. We still your patches for EXPORT_SYMBOL. -Chris