Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3460559ybl; Mon, 12 Aug 2019 00:26:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzx8tpTymdWeSyX+g1cjI1lEPL4vu/pFtm9njjlfhYAnT+pn/mWtuWszAn5X/CUkeHUp+/C X-Received: by 2002:a17:902:9a06:: with SMTP id v6mr30798012plp.71.1565594808583; Mon, 12 Aug 2019 00:26:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565594808; cv=none; d=google.com; s=arc-20160816; b=v9MnJ8UXsu6j7z2jPs7vmHuXB1tpbuszm/IK7wodbTG9JJSsV5IcoPqMolqDoNkfgV UXalrr4p87splip7Ghuz3kK8ImvEHhd2Ipfesqiw9ZRjTBt3cG9BT8F40yCQT7Cbg9GM n6umeEuFCQCoG2WpCy9CfYFB9eJzUQVcLHUnwxBT0QNQ+mZ9E04VFNPB5nygNEEjDZUG QNUchq2uOSYWfszcZ5e1+FRQAWVzhF45YpLlbrTdVxe4nMSJ1Q9k9rEGKgIjQJDkpZMw u7ffMmdH7mwJxz6jEj/WttlbtVii4kL1c69WFw/QCyHyE/V5HZDXFf5LJVvaH2i5DW0t am8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v3qFXuuCyhEZaSKmlx5nKQ+CnqDEnPPc+kBNB7h+EyI=; b=ArZdJ8TOE4mYs0trd4VufzOwph19S4vS/5/+oorhKXcTx3fdZQQffqXZbA5pfK9kv9 nbIY4W6XgYrThPpjEGuMjagWHs+WHYPtbir0f574OVEFTc5inUokx2xEMAbMKWfmJqTv UA/8m2ATJV8aZqKiD+4ygooPR0wCdPHBdp29sB8w/h3AQmTPNSn+6r0fhpjYqRlQEjpR qnHKk94ksdMWrOZzpL46uW1Fok0l/j6uok5nisDykt1FJEFklPScrX93kK37aG4rKrDu QVqAATQBV6ke6CBDVPDYWqZu5olpmVARq9vpEPv5UTDdIar7+mnag7eOTp6GWys2yd2E FzLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7UG62hb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si891271pjr.26.2019.08.12.00.26.33; Mon, 12 Aug 2019 00:26:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7UG62hb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbfHLHZg (ORCPT + 99 others); Mon, 12 Aug 2019 03:25:36 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34538 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfHLHZg (ORCPT ); Mon, 12 Aug 2019 03:25:36 -0400 Received: by mail-wr1-f66.google.com with SMTP id 31so103696640wrm.1 for ; Mon, 12 Aug 2019 00:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=v3qFXuuCyhEZaSKmlx5nKQ+CnqDEnPPc+kBNB7h+EyI=; b=v7UG62hbv+/m4lw5vD/c3cbTFwsKCgmZxX+rl0srP2Bp4sOACsDJeUp2JKisxT2veD wrUEDTVCbdvqqFDBM3n8UOI/BF34giJv0IoCrT79zo3hOIJlKEmZTtZC1NgbWKfes7i2 xdV952S1jHUzGQFD1UtZHZmK5mV7Aiv+ppXfzju6aLUf4DcgBQW8Ek/o0M3WvblUStmq D+BnqWg8cH8E2plNdkldhbPQlANtApkX6WKKxonKAlaHXl27rmNaFvpTjcD30d6+r7yg QRGbiYGOK8N/995PSnoX2QtvpjlTROKmdP1ovTwnTKQWn3H0QDkTxDj/7b4CVO7+V1we zkZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=v3qFXuuCyhEZaSKmlx5nKQ+CnqDEnPPc+kBNB7h+EyI=; b=PiUuE5YMUJMf/lFsyYcmCb0zJbiM0clwCfeG3Tsr1hF/rbyuWZfIBoIo3JCj+nvdO6 koOjq1rYHnUOyXXxfvL6PPR3tRxUNegQo75Fav2oyv02dd3txODatnNsMEzmjCmt5kJu cNfPCxy+LUXWdWnvgxuHDlcGgNKBm/PWfB3bO4qDIpoBg3Pf2M4IjJV6V1uTK2Qtet63 uOBL6cT61EWi6iWARL1rYtLW0CuPuw7kGGEAK3PbgvBV4pe2g5Kt2e489CoUYOscMrhp tJi/AcSmPqq/VqN9nJDPWgHp5nKPHuysW3tJVj+N59oWsBHpTwa/uQOa8Kz0CIC7iipH VBiQ== X-Gm-Message-State: APjAAAV8dgy7yXOQJDd9qlY/RoCNl0B0Xy4SGPLc/aS0f3tNSOyqqATO s+MHRkujS43dqd77IhvNlZGBoQ== X-Received: by 2002:a05:6000:42:: with SMTP id k2mr37673695wrx.80.1565594734003; Mon, 12 Aug 2019 00:25:34 -0700 (PDT) Received: from dell ([2.27.35.255]) by smtp.gmail.com with ESMTPSA id w7sm119249660wrn.11.2019.08.12.00.25.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Aug 2019 00:25:33 -0700 (PDT) Date: Mon, 12 Aug 2019 08:25:31 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , Krzysztof Kozlowski , Will Deacon , MyungJoo Ham , Chanwoo Choi , Benson Leung , Guenter Roeck , Jonathan Cameron , Dmitry Torokhov , Mauro Carvalho Chehab , Sebastian Reichel , Thierry Reding , Alexandre Belloni , Liam Girdwood , Mark Brown , Neil Armstrong , Greg Kroah-Hartman , Collabora kernel ML , Andy Shevchenko , Gwendal Grignou Subject: Re: [PATCH v5 07/11] mfd: cros_ec: Use kzalloc and cros_ec_cmd_xfer_status helper Message-ID: <20190812072531.GK4594@dell> References: <20190722133257.9336-1-enric.balletbo@collabora.com> <20190722133257.9336-8-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190722133257.9336-8-enric.balletbo@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote: > This patch makes use of cros_ec_cmd_xfer_status() instead of > cros_ec_cmd_xfer() so we can remove some redundant code. It also uses > kzalloc instead of kmalloc so we can remove more redundant code. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Andy Shevchenko > Reviewed-by: Gwendal Grignou > Tested-by: Gwendal Grignou > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/mfd/cros_ec_dev.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog