Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3460742ybl; Mon, 12 Aug 2019 00:27:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqytJa7bFl3jt4fEFWutwPPNyLpZkaAVcrbscUdQRrMONstOJLd7Vo22ZeExb4b0hp2G9sBk X-Received: by 2002:a63:1918:: with SMTP id z24mr27774306pgl.94.1565594824435; Mon, 12 Aug 2019 00:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565594824; cv=none; d=google.com; s=arc-20160816; b=Q/0QOVYq9TOhSlWdg/xJVyD3Z1L6n3JIzElRLMIwgU0ldV2kMZ3KhvRLKP2d6w7TPC /uKLc5xatIbPQqLR7H45FEy//BSIkv+QXYL/JlaCzqzagfQ/vy50UZ0uYDZfKZQAJmaD fg7knUZi6LdhTkoUDeZLq/vuNRAePkyIxWHMHOf8VTalbCjZhHP9/iqA0s6CHtd9CXha Qt7TK/czz2DYvyTOQaGspHUKi7vNOZsOEy1bJEPewCSR7n2xC2HclQeaLG2vHCOAzbQT kDyWpbVnwolhZo2qg5uPO0TyETKPxZLDBxAM8TTMzrFCC5XG6Hw/gTXR3CyrVFu/GAqh nAJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tXk2RW16lQ2ByKWP571LcOH/rEVKPhvpFkOpaKcZwDQ=; b=klCb3bxJOe1GaXF+1LX5woNb/RFiljEYQjCc3+b9eRhxSGChHTYidLmySqf8S57ztC IFU5Y3Eiy4q5G3fpfytq6xnS+btOkx7Y1o/7kdQbuAnaxfY9pTSmVJOkiJlyC7+ibFT7 9DP2pZr8ymAfWiSkDLIbcg/fm+dP4N0bTFD9fJJLL99NO0/rdqW6X2+nzEasNOm97wfl N8FaWFTSKRVaIy1NI7ow4d5UHDVQvE1mYIHhoAVF6bhKRlkovWFukhPZTFTfZTlxUvNk 4bP4hfv7Uo4QG7ZbW67PI7zgAECyAEdYSwtdC0wsQByW4nfwCcu22F12f28P3DFrapgv 1iNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tG0A6dG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w190si10484415pgd.229.2019.08.12.00.26.49; Mon, 12 Aug 2019 00:27:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tG0A6dG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727086AbfHLHZo (ORCPT + 99 others); Mon, 12 Aug 2019 03:25:44 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:33831 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfHLHZo (ORCPT ); Mon, 12 Aug 2019 03:25:44 -0400 Received: by mail-wm1-f67.google.com with SMTP id e8so9962457wme.1 for ; Mon, 12 Aug 2019 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tXk2RW16lQ2ByKWP571LcOH/rEVKPhvpFkOpaKcZwDQ=; b=tG0A6dG9qOdEGSl1oJwMiWG1aNxgFj5NfRvt2j61VyL1rtYkMWnXJQGI2qxLkY3zCa JOCjUgAxdBjQ8MkDVbQ7iM+5lMk/0gIEbEQ7vjw8cbiKb+5xqgRomEUKjjXAhmiSTIPt ZMePKlCMOg4LTLGtgfRpfOR3936CIRQHzcSYBGmYecjoMegi+5C8v4KjuXlnVSJsihCz mTfdgjikOMK2W+KULEIsO54AKWcgKWfN0Ya1VNWgcVKqufW46m64rzII3FSJfq/pg/3j 0G6wL+VAdkFjt40PaykNwIIDnOgHOaiRR+imjya3As5+HNOlj88JeGfZI6OMfSDXX58G 484Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tXk2RW16lQ2ByKWP571LcOH/rEVKPhvpFkOpaKcZwDQ=; b=riFrDEYXFFANJxLTONrf3PARF2m2WTv7YUDyzTEkXPxYNazIxx6AoFF9GIEm6IX+Wx V/PhU88UXjlsVD0qrWqdzhWfoe8JePgxJ4bjuqb5tDcjbPHRoPzw6no7NA0k2cJKsAMk P6RxqBj1WD4qoy8nucZk1M04PMfmVFVozAUcT4yTCnrON0j/l91btbTl7SoKJH9C84t/ vthXifFKOs2JzAHt8sQYdSPRLB1xRLwxoHxIFRG8A0Y+rLu/K/amz46Xqu7lqQuXM4Ys 8YSMyLNnmOFMPqKk3rFfDOn9pUKrzue47kAErCWv9IHfWMrSxXO5P8wAXBFZ+ntjKaKT Mhlw== X-Gm-Message-State: APjAAAU8Nom4kEP99uRdxPGd9H429CYyS8uL6wgVWyR/5Y3cYBWkLtmg S1RxqvOVKbQuRIiDA2TdYUHa9w== X-Received: by 2002:a05:600c:145:: with SMTP id w5mr1487403wmm.75.1565594742463; Mon, 12 Aug 2019 00:25:42 -0700 (PDT) Received: from dell ([2.27.35.255]) by smtp.gmail.com with ESMTPSA id l62sm7118863wml.13.2019.08.12.00.25.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Aug 2019 00:25:41 -0700 (PDT) Date: Mon, 12 Aug 2019 08:25:40 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , Krzysztof Kozlowski , Will Deacon , MyungJoo Ham , Chanwoo Choi , Benson Leung , Guenter Roeck , Jonathan Cameron , Dmitry Torokhov , Mauro Carvalho Chehab , Sebastian Reichel , Thierry Reding , Alexandre Belloni , Liam Girdwood , Mark Brown , Neil Armstrong , Greg Kroah-Hartman , Collabora kernel ML , Andy Shevchenko , Gwendal Grignou Subject: Re: [PATCH v5 09/11] mfd: cros_ec: Add convenience struct to define autodetectable CrOS EC subdevices Message-ID: <20190812072540.GL4594@dell> References: <20190722133257.9336-1-enric.balletbo@collabora.com> <20190722133257.9336-10-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190722133257.9336-10-enric.balletbo@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote: > The CrOS EC is gaining lots of subdevices that are autodetectable by > sending the EC_FEATURE_GET_CMD, it takes fair amount of boiler plate > code to add those devices. So, add a struct that can be used to quickly > add new subdevices without having to duplicate code. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Andy Shevchenko > Reviewed-by: Gwendal Grignou > Tested-by: Gwendal Grignou > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: > - Use mfd_add_hotplug_devices helper (Gwendal) > > Changes in v2: None > > drivers/mfd/cros_ec_dev.c | 131 +++++++++++++++++++++----------------- > 1 file changed, 73 insertions(+), 58 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog