Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] media: docs-rst: Clarify duration of LP-11 mode
To:     Steve Longerbeam <slongerbeam@gmail.com>,
        linux-media@vger.kernel.org
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20190811173621.20454-1-slongerbeam@gmail.com>
From:   Ian Arkver <ian.arkver.dev@gmail.com>
Message-ID: <3f31cde6-8faf-f9a0-626e-dc995260a640@gmail.com>
Date:   Mon, 12 Aug 2019 09:53:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190811173621.20454-1-slongerbeam@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

On 11/08/2019 18:36, Steve Longerbeam wrote:
> Add a sentence that makes it more clear when the CSI-2 transmitter
> must, if possible, exit LP-11 mode. That is, maintain LP-11 mode
> until stream on, at which point the transmitter activates the clock
> lane and transition to HS mode.
> 
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
> ---
>   Documentation/media/kapi/csi2.rst | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/media/kapi/csi2.rst b/Documentation/media/kapi/csi2.rst
> index a7e75e2eba85..6cd1d4b0df17 100644
> --- a/Documentation/media/kapi/csi2.rst
> +++ b/Documentation/media/kapi/csi2.rst
> @@ -49,9 +49,13 @@ where
>   
>   The transmitter drivers must, if possible, configure the CSI-2
>   transmitter to *LP-11 mode* whenever the transmitter is powered on but
> -not active. Some transmitters do this automatically but some have to
> -be explicitly programmed to do so, and some are unable to do so
> -altogether due to hardware constraints.
> +not active, and maintain *LP-11 mode* until stream on. Only until

s/until/at/ perhaps?

Regards,
Ian
> +stream on should the transmitter activate the clock on the clock lane
> +and transition to *HS mode*.
> +
> +Some transmitters do this automatically but some have to be explicitly
> +programmed to do so, and some are unable to do so altogether due to
> +hardware constraints.
>   
>   Stopping the transmitter
>   ^^^^^^^^^^^^^^^^^^^^^^^^
>