Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3567882ybl; Mon, 12 Aug 2019 02:42:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyISrN6cFD/knUMLbkvSjvnIlwMNwawL+dJ+KnTCl/PYTUWcHfRC/0EcEYnmn/E1Oj+snyH X-Received: by 2002:aa7:8711:: with SMTP id b17mr35251573pfo.234.1565602970287; Mon, 12 Aug 2019 02:42:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565602970; cv=none; d=google.com; s=arc-20160816; b=piirJ9giCkeyv5wnFEWAG+5q/T/9SyFROERyWGCwQ1FU+V1XxB/hLpNo+mhbp1kZqv kwupdbCxQzcz9EZEQEtkSEJaMZNv3aO2Sjxbyxj/EZKpNjz3ubakD3M0AoX5EnnYuihS QNdSRQiiZtiYf9TZtksM+BmyELQrcfMAKWM/b3+Cn98cQaWYhyTef7q9uHv81dAK6xDb DQu+/NEd9afeSOL5JyEbrD3g65uLb0PP6x1O1JpueuyF7m7qZ50tpgpKJRaTkGN0KKYP rQm1sboz46kSv5l1EixUWgAWy2VVhquVELFCnjhjJz79lg2/PI0S8o6Pqmxuh1iRm7Fs +b0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Msh3pDWA5n2bwbvwOe6T3wbzv8X8I0bKeghPq+dNzE0=; b=qsY4Pe5LKw8O8WhfYuAnBKMbkaosoSUxmJUqD6z/rf6VpxQEQfshAjE8VPymdJ80kN u3oiqk83fAyHtYRDyAVQ10jxVXlOlszMz7UYATw8SVrXAfMlx8xIiSvupjDxDFYZ1rOK xJj+XcfSDs/Z3AFNmcf2CJSDxlSnKZ3GO4FGgvNRl7s5PwG9Tb/4s79zfDF0kVBj5LH0 FgSpkyehO8AjDoQ1zZLaVQUZBhd3BpoB6MW1a3Ybq82F5wtqz1L5t/rqIIWymjgclmi4 G+Sfl5x0ZhpNNqPaxExU9fVUxeOwP4IlGENxZJukgMkmLgQIZd87RmVTwIvFKim7MJP/ TINA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cj11si57505948plb.373.2019.08.12.02.42.34; Mon, 12 Aug 2019 02:42:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727606AbfHLJkJ (ORCPT + 99 others); Mon, 12 Aug 2019 05:40:09 -0400 Received: from inva020.nxp.com ([92.121.34.13]:49666 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727297AbfHLJjf (ORCPT ); Mon, 12 Aug 2019 05:39:35 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 31C4B1A0658; Mon, 12 Aug 2019 11:39:34 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 25EBD1A011B; Mon, 12 Aug 2019 11:39:34 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id D9803205ED; Mon, 12 Aug 2019 11:39:33 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH 04/10] staging: fsl-dpaa2/ethsw: remove debug message Date: Mon, 12 Aug 2019 12:39:12 +0300 Message-Id: <1565602758-14434-5-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565602758-14434-1-git-send-email-ioana.ciornei@nxp.com> References: <1565602758-14434-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since ethtool will be loud enough if the .set_link_ksettings() callback fails, remove the debug messages which do not add additional information. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c index 95e9f1096999..12e33a3a1bf1 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c @@ -91,8 +91,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, struct dpsw_link_cfg cfg = {0}; int err = 0; - netdev_dbg(netdev, "Setting link parameters..."); - /* Due to a temporary MC limitation, the DPSW port must be down * in order to be able to change link settings. Taking steps to let * the user know that. @@ -116,11 +114,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, port_priv->ethsw_data->dpsw_handle, port_priv->idx, &cfg); - if (err) - /* ethtool will be loud enough if we return an error; no point - * in putting our own error message on the console by default - */ - netdev_dbg(netdev, "ERROR %d setting link cfg", err); return err; } -- 1.9.1