Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3571699ybl; Mon, 12 Aug 2019 02:47:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqypWwhdwmi2awUIWA9SyErKsDN1CqC4V1JxnEx4PRpd9sF8xd8vq26c2v5wjVXuTSrl9z9a X-Received: by 2002:a62:3347:: with SMTP id z68mr35670151pfz.174.1565603247408; Mon, 12 Aug 2019 02:47:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565603247; cv=none; d=google.com; s=arc-20160816; b=X1nupqqj1KFB2r4GgXy1e4grN1Eqz+s8EUVA+sFo32qO5fDEF/LobYiIi6RgwCmTSd F2I4whMQ8XaGEMLsRGSDYcfhGskDTD6hEEcA1F0YZFlyC6/dWQPPyOAjIyK1NDPsAPTI YSrSD+l8A1PTquatT7QFf+SvId2lyQk26AbY5BrBNMSIyojyw/IE0KOa30+l1eM24zI9 4EeeikZF8D2eZ30IYBN9PwOouNcaJmYHLFqjcpaUcVvYIfatxdRfA7rP+yXTLQMv69Ep dou9BIprgpiFOAFZeaoO/x5JSywmCjZwDKxFrahOcCxvHjOwz3OIdV5PwA/SrUKPUymt U/1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=F7yAR5r+/ty0TLaJfG6Zc4X5A2C25vU0TT/49Mgh7FE=; b=qGSQAdc0vduiq3m5xtjDK7kYcFp+xbKCoBUUZhxXSidoC39xlU2TM7YOaXfaBruK9t NJ4nkf/LCScj8ib5yVXsDSZ/xMLGjSQW37UVEaSvT5qbbfomAf6GaFHmyptIGh+qHjG7 xxntscGu9q4yElvl6pMej1jUIw3ABZ2FLoBVunHR2y4Dt2DuXdzrTIzgTy4/1cmUlz1A 7s9TvD+4iWUitrX50Qhvx8020Mq4uisl/199hCBgShfyvmDGKix6u+1F6MWb7Ts47M9Y XIe0nqgTbDTxaYYIP49f1q2j2g2mLUIQpaj/1HbTi+XCBPVBgbzBwEabrqVL4Yxn1vzm yidg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si3480477pli.229.2019.08.12.02.47.11; Mon, 12 Aug 2019 02:47:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbfHLJqO (ORCPT + 99 others); Mon, 12 Aug 2019 05:46:14 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47963 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727425AbfHLJqN (ORCPT ); Mon, 12 Aug 2019 05:46:13 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hx6u0-0001xp-3O; Mon, 12 Aug 2019 11:46:08 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hx6tz-00089g-1q; Mon, 12 Aug 2019 11:46:07 +0200 Date: Mon, 12 Aug 2019 11:46:07 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Baolin Wang Cc: Thierry Reding , Rob Herring , Mark Rutland , Orson Zhai , Chunyan Zhang , Vincent Guittot , linux-pwm@vger.kernel.org, DTML , LKML , kernel@pengutronix.de Subject: Re: [PATCH 2/2] pwm: sprd: Add Spreadtrum PWM support Message-ID: <20190812094607.yg7efmvefewxicke@pengutronix.de> References: <6a38a3655bc8100764d85cb04dea5c2546a311e1.1565168564.git.baolin.wang@linaro.org> <40127356a1acd1f2ff1be1d8a120b305a4e17af4.1565168564.git.baolin.wang@linaro.org> <20190809091013.vguj4wty7qiab64t@pengutronix.de> <20190809144124.3as3rtctlywxkudr@pengutronix.de> <20190812083556.dvprpwv6mjy3cjae@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Baolin, On Mon, Aug 12, 2019 at 05:11:56PM +0800, Baolin Wang wrote: > On Mon, 12 Aug 2019 at 16:36, Uwe Kleine-K?nig > wrote: > > On Mon, Aug 12, 2019 at 03:29:07PM +0800, Baolin Wang wrote: > > > The clock framework supplies 'assigned-clocks' and > > > 'assigned-clock-parents' properties to set parent, but for our case we > > > still want to set a default clock rate if failed to set parent when > > > met some abnormal things. > > > > Without understanding the complete problem I'd say this is out of the > > area the driver should care about. > > Fair enough, I will try to use 'assigned-clocks' and > 'assigned-clock-parents' to simplify the code. There is also assigned-clock-rates if you need that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |