Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3742011ybl; Mon, 12 Aug 2019 05:44:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqymoLFkIkVYLHb8OIMII5gimCpkDM0kEBywau3ScUzHELsM/h+ReJbnlD87KPYgd7aJFuUL X-Received: by 2002:a17:902:2be6:: with SMTP id l93mr33175187plb.0.1565613875264; Mon, 12 Aug 2019 05:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565613875; cv=none; d=google.com; s=arc-20160816; b=eyHWQaKIhFgkYP9HB8UbLS4M3T2O0l50dB3j5QL0exmEdlFhuADXINR9ZG9MfpIOIz GeoHHwW7pPkyQ0R7T0RvmlTZF6ch7AzkGtXmp16g2Z4syDVxBsgVbacj1Vssea59bvFn ezau4JF+GVLU9CRQt0XUDYaDa/uPBDMnV/MFeUwbu5MLVAtL4phys0gFSqAbKwK8tMFN cN70cP+Ed3Z85icsb0J2y6wZJVQrdj8DSxXzOoajh0Wfo80D6UPxFuTkm5scfJkNuDrX W6vkm7/v7X78sb9yNHSfodRxI9MXtFbEPN3yUftyvtchBWu6ZlrxCIoOpL8neu3NiZft o/mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:dkim-signature; bh=KxPesubEiD+bCR7nkBTXNts6iOofw5KUnCn+J1EgO88=; b=Pe5SXUqgEISUj71lfCDa6XQZXUWeHxssPMaQrBeh/95YV5XpZtaPhHggnnknhj8oV1 juP9O8kkGrj2NUJRUGocQCrivlEBFJ2sW2LL4XPtSmR0Tevp1BYKZ4kgLwzykJlo8EAG kauXCdBY6SJ7IxgzcTCxz1mhru8bktLgCOhvaM8EzPNakm/Ya1nm8bqXaRKFs0IKUWwp 4S2quenr31n+ecyOykvpap7bIHVP7IUrXS55Zi1F7/4quBjpd8P5mrsXfN8xaYBee6Uh SxTjRbR18WKKSZOnKj3PCucMVpzBik7h2uZN0U1KQ6ayqgmBD177GFoa+FZ9YW1ge2UH YlSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=es3oqqAy; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=iKJ+QxIV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si65167523pgn.360.2019.08.12.05.44.19; Mon, 12 Aug 2019 05:44:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=es3oqqAy; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=iKJ+QxIV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfHLMl7 (ORCPT + 99 others); Mon, 12 Aug 2019 08:41:59 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:35776 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbfHLMl7 (ORCPT ); Mon, 12 Aug 2019 08:41:59 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7CCcisk128905; Mon, 12 Aug 2019 12:41:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=KxPesubEiD+bCR7nkBTXNts6iOofw5KUnCn+J1EgO88=; b=es3oqqAyIwEbiXI4a5tmJFiDc+yY3pew0qBjcoriipuPdj1bjiVq5Q1+V5Dptj44pQz+ PQLsL2a8M5oC6KfqdMtEsGb4FrR4h2mqaNzHP8WkoC3k3pPPP3Z5AKYHO+b9Y+fRwxaD qSmC3VQbTXg/ZyCi+Wes8rJPlwonnrjGyPTyoM/XPgSiErbuLX69mC2ZC+rzvDEV4uxV XGtlDIOCP4f0XqUIBKAnylri7DttKdYaaaMZ6SvWhkKQARH0OeJW4i4RjA20CVjXNdMa aGuxJBttb9AzA1ddQAC53xcXNBzFilkuh/fTNgqDV0vzO48pRhKUlgeot0oA+pczdSPV VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=KxPesubEiD+bCR7nkBTXNts6iOofw5KUnCn+J1EgO88=; b=iKJ+QxIVxrDoKNlcEsaFcsnPLf5UHaFHiTpNpHsUHnVTiqhP+U52mfZXdSazvS+D6/lG EpWKxMS2J+cgJMYs7VX4bpOwC+za/kyq8nMr//xFqlBJMlLhWDrGLVDnXtV/ksXDOaHX 4qj92pBma7QV91frQn73bEfNm+oqCUe5gP+k6FCaEn4/yhy6aSyz87DnsgvHxE0ti+/Q ufiiis1AbbSQ56wbjPbHkpBfo9Qw/Wj1n+K+RZWFbPUEckQ9KToZRL0STJpzOWUC5nh1 xbHrxk8IQfhrimez86xEZH7RUMcbJCLlWk512/zHUGxnccMIfMt53NJKyt/GpNGKiY4f Pg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2u9nbt7eh2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Aug 2019 12:41:48 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7CCcrTW163641; Mon, 12 Aug 2019 12:41:48 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2u9k1v4wk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Aug 2019 12:41:48 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7CCfkv2017477; Mon, 12 Aug 2019 12:41:46 GMT Received: from bostrovs-us.us.oracle.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 12 Aug 2019 05:41:46 -0700 Subject: Re: [PATCH] xen/blkback: fix memory leaks To: Wenwen Wang Cc: Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , "moderated list:XEN BLOCK SUBSYSTEM" , "open list:BLOCK LAYER" , open list References: <1565544202-3927-1-git-send-email-wenwen@cs.uga.edu> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= mQINBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABtDNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT6JAjgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uuQINBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABiQIfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Mon, 12 Aug 2019 08:41:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1565544202-3927-1-git-send-email-wenwen@cs.uga.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9346 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=933 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908120143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9346 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=987 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908120143 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/11/19 1:23 PM, Wenwen Wang wrote: > In read_per_ring_refs(), after 'req' and related memory regions are > allocated, xen_blkif_map() is invoked to map the shared frame, irq, and > etc. However, if this mapping process fails, no cleanup is performed, > leading to memory leaks. To fix this issue, invoke the cleanup before > returning the error. Reviewed-by: Boris Ostrovsky