Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Philipp Reisner' <philipp.reisner@linbit.com>,
        Jens Axboe <axboe@kernel.dk>
CC:     =?iso-8859-1?Q?=27Christoph_B=F6hmwalder=27?= 
        <christoph.boehmwalder@linbit.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "Eric W . Biederman" <ebiederm@xmission.com>
Subject: RE: [PATCH] drbd: do not ignore signals in threads
Thread-Topic: [PATCH] drbd: do not ignore signals in threads
Thread-Index: AQHVRehdZ3MFgEc+dUGpXqE3QyW7xKbhRpmwgAr+X4CAABFvoIALFfUAgAAg40A=
Date:   Mon, 12 Aug 2019 13:12:16 +0000
Message-ID: <1fcbb94c5f264c17af3394807438ad50@AcuMS.aculab.com>
References: <20190729083248.30362-1-christoph.boehmwalder@linbit.com>
 <ad16d006-4382-3f77-8968-6f840e58b8df@linbit.com>
 <6f8c0d1e51c242a288fbf9b32240e4c1@AcuMS.aculab.com>
 <1761552.9xIroHqhk7@fat-tyre>
In-Reply-To: <1761552.9xIroHqhk7@fat-tyre>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Philipp Reisner
> Sent: 12 August 2019 12:53
> Hi Jens,
> 
> Please have a look.
> 
> With fee109901f392 Eric W. Biederman changed drbd to use send_sig()
> instead of force_sig(). That was part of a series that did this change
> in multiple call sites tree wide. Which, by accident broke drbd, since
> the signals are _not_ allowed by default. That got released with v5.2.
> 
> On July 29 Christoph 	Böhmwalder sent a patch that adds two
> allow_signal()s to fix drbd.
> 
> Then David Laight points out that he has code that can not deal
> with the send_sig() instead of force_sig() because allowed signals
> can be sent from user-space as well.
> I assume that David is referring to out of tree code, so I fear it
> is up to him to fix that to work with upstream, or initiate a
> revert of Eric's change.

While our code is 'out of tree' (you really don't want it - and since
it still uses force_sig() is fine) I suspect that the 'drdb' code
(with Christoph's allow_signal() patch) now loops in kernel if a user
sends it a signal.

If the driver (eg drdb) is using (say) SIGINT to break a thread out of
(say) a blocking kernel_accept() call then it can detect the unexpected
signal (maybe double-checking with signal_pending()) but I don't think
it can clear down the pending signal so that kernel_accept() blocks
again.

> Jens, please consider sending Christoph's path to Linus for merge in
> this cycle, or let us know how you think we should proceed.

I'm not sure what the 'correct' solution is.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)