Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3777143ybl; Mon, 12 Aug 2019 06:16:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwD6BAIvKN+NE3TR+gwgZSYo6m4+uszUemP8HlMGMsyXStZyRkOm1jz9u754LzNOnCNJx6/ X-Received: by 2002:a17:90a:8985:: with SMTP id v5mr23010613pjn.136.1565615779097; Mon, 12 Aug 2019 06:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565615779; cv=none; d=google.com; s=arc-20160816; b=I3hY6H4DIVGJucRJTYSdZ98B97zx7SE1cNKFVJsJIdEHgVV42fQ5tLyZqDonGko1Gf sb8tEZ3cyR0/Ze7gXSg/PngxZFStMcQXmnSY/FewNeDHA8bEFCJB+KvFvMrUIYQ+Xs12 QPuGw+8VStHBvoDm+eXA9hnBLsJertQTVGMg4Otc8RtF6XbkU77Tu8dbjR43UJYIIXrV zkGrA7hCPRoV6lzl0hmoMu3bWJa6dA+jJIPXzIOR+UrgeeGZI5BhIjMEDxf6Id1XbKRE x8R0IooRybwKocOCX3WEiYlx0rJQADsJP4h0X9NWskvocl5Ma50sFDtGQfARnOWQxfoV oWCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=WQvr6xhw7jlV2bbdPZ+TwkWaOyuSvHO2q15OLx+jlxI=; b=0RoXYu6yEhyHZsclrQicuGIgpER5yc06DracAdoROBEoPy8ue3B1JYxAsYUg5klt2H FSK7c0Epd6P9L52Us9/QyhLfKEqTY5qumtic9Jmz2BU4NN87Mp5MYSYsGWkXqi4k6RxU y+87YHLmcJ8YEdv0507W3DpbUlgWlPzzF7ugm4zAmXOotDTDNrbdB8AQpnHkM+bbW0kP 7ejUkvHe7GizYrlqeN5tW33g+ZowN58Bt9tuPYaMKImOgZFB1fwMbw4DWmAFe4IH09kV yvpl6eCuB0hXYr31h1u7Yde+NjIfsQKeYp2bigCOqu4gCt8+y4Io8Q//z980DdoL/nz5 p75g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si27127854pgu.153.2019.08.12.06.16.03; Mon, 12 Aug 2019 06:16:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbfHLNPI (ORCPT + 99 others); Mon, 12 Aug 2019 09:15:08 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:40203 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfHLNPI (ORCPT ); Mon, 12 Aug 2019 09:15:08 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 466btK49TZz9sN6; Mon, 12 Aug 2019 23:15:05 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: b9ee5e04fd77898208c51b1395fa0b5e8536f9b6 In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Chris Packham From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/64e: drop stale call to smp_processor_id() which hangs SMP startup Message-Id: <466btK49TZz9sN6@ozlabs.org> Date: Mon, 12 Aug 2019 23:15:05 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-08-08 at 12:48:26 UTC, Christophe Leroy wrote: > Santa commit ebb9d30a6a74 ("powerpc/mm: any thread in one core can be > the first to setup TLB1") removed the need to know the cpu_id in > early_init_this_mmu(), but the call to smp_processor_id() which was > marked __maybe_used remained. > > Since commit ed1cd6deb013 ("powerpc: Activate > CONFIG_THREAD_INFO_IN_TASK") thread_info cannot be reached before mmu > is properly set up. > > Drop this stale call to smp_processor_id() which make SMP hang > when CONFIG_PREEMPT is set. > > Reported-by: Chris Packham > Fixes: ebb9d30a6a74 ("powerpc/mm: any thread in one core can be the first to setup TLB1") > Link: https://github.com/linuxppc/issues/issues/264 > Signed-off-by: Christophe Leroy > Cc: stable@vger.kernel.org Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/b9ee5e04fd77898208c51b1395fa0b5e8536f9b6 cheers