Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3819224ybl; Mon, 12 Aug 2019 06:58:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDrX/2OWQiyf8GX85nSA/NxR2lSz5r11ycVuoJLZ0mKucLiFNoTWx1oVZUgxhKiw5DxcV1 X-Received: by 2002:a17:902:ea:: with SMTP id a97mr32751540pla.182.1565618332586; Mon, 12 Aug 2019 06:58:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565618332; cv=none; d=google.com; s=arc-20160816; b=ile5SUQXl7Mo7kHoyzqWRS6ljv2FiQoA/KBx2s2DXjnyVmmWAJEk4KBO8ybK+4bh/b rJuOX67BCNsKyzbIFrxuDKE66TITWHbXhfpU5Ovo3L772Ps4aBtn1YcQuHSk1AtHTKwH vcgpTL6SxqQfq7R296C4pf4pMQCLDDlgo/MKXREeZG4XnBAwyE57E2WFRBVMdBSMt1DP LeDeZ8uNNoU+aHe7OgMhXg7eaqoKutm+1aVw0+iE9wUsKPiCJNYFQjF9SJxcypes0sc4 m93XLrO/dwMcCL36z2LQ2m0mr7lhTKtrADu8wDQ8K6wPlR+TELvlQjPxa1Ogw6+m7EGe BjUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sOTJPwoCws/W5B4gjQ5XrTQUGLpEMhk29kPSAYtagHs=; b=OaGkLYnklPrOo5sCVc4b2AW4R9x9ftuT26yM7cXXVvCVAyKo3SMZl9G9DhAfYn0Ts5 jTRNy9MdM+sICR9EwdQOypmtwwTpiv0wgCSNuRit8ePTFBjdl80rs31gfLY5s+h0oJQ+ y7nCPPUk2Kh8FLf6pTin3J/Tp1IH0mtDFn3OhoFseNUu4Kr3QVatGhrBc1lJXV50c6T1 wsdXxy6TLHHn5zWI9pa/SXqy3K10Tyhp3oBS4EzQAdmcRM5DiRSO6s5MuQbxjXLC4Oks gcLaHndJ/gQi7+FECrAyA/tFTV+rFUlBWlZ4BA5hk90LIiHh4ceem7GMjWcpcmQS5kGa vLhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=pYCNqKVD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si54011455pga.462.2019.08.12.06.58.36; Mon, 12 Aug 2019 06:58:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=pYCNqKVD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726696AbfHLN4S (ORCPT + 99 others); Mon, 12 Aug 2019 09:56:18 -0400 Received: from mail.skyhub.de ([5.9.137.197]:41672 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfHLN4R (ORCPT ); Mon, 12 Aug 2019 09:56:17 -0400 Received: from zn.tnic (p200300EC2F0627009817776DE5A4173C.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:2700:9817:776d:e5a4:173c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 867A61EC0716; Mon, 12 Aug 2019 15:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565618176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sOTJPwoCws/W5B4gjQ5XrTQUGLpEMhk29kPSAYtagHs=; b=pYCNqKVDhyKc71xmMVdmJNJ0ZlCt2f7s+xxBa4SW2H6x/Zp/9VOq9niuE+n6B1/pGs0Y1a r0+PBSURnEi2J+zAcesR2CXAhK9mfXT8fZhzGZik0v5dLutGf3RDCBbFJW0Y9rjUqLHB9m jkk5BvQXM3nNjq7mashohehhgqmXgb0= Date: Mon, 12 Aug 2019 15:57:01 +0200 From: Borislav Petkov To: Thomas Garnier Cc: kernel-hardening@lists.openwall.com, kristen@linux.intel.com, keescook@chromium.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Nadav Amit , linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 11/11] x86/alternatives: Adapt assembly for PIE support Message-ID: <20190812135701.GH23772@zn.tnic> References: <20190730191303.206365-1-thgarnie@chromium.org> <20190730191303.206365-12-thgarnie@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190730191303.206365-12-thgarnie@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 12:12:55PM -0700, Thomas Garnier wrote: > Change the assembly options to work with pointers instead of integers. This commit message is too vague. A before/after example would make it a lot more clear why the change is needed. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.