Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3886781ybl; Mon, 12 Aug 2019 08:00:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFuGULidx+3CDS5VIe2hVDmRlUgWYVGs2bKFJ0opfeaDiKP4BJy0/TluEmtTNdLs3dt3eb X-Received: by 2002:a17:902:1027:: with SMTP id b36mr21918464pla.203.1565622043677; Mon, 12 Aug 2019 08:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565622043; cv=none; d=google.com; s=arc-20160816; b=YoLxHkhZGKzoTwSd4hGYu6AJToe0taz2fUpu67uQ0qIkChElCjyKbCrVOJfrWlIbER GrF7sF1czIRC0TdBhLNXIGSYKxvFbzLrBzYB2aO9Nqn9qI+I0L7Vv7B+rNYuD3nx1veK dQnspVdXLO2Wclj45JcYQn8ozpbuA4YrhxyYGjjFcW/gonK7h0X/gJOOymyBU6PtjWql 1a6eIJWaw1EvcYJKn3dJshaajcEyXHPuQwP6raAlnZpHdgnCidlIPBwUHL2OxuzgaCWN i7Z4X+1c+qjLQ3j2repN2X88wfJKrBEqg2Lh5Wip0hVvubqTjQt6q8OFnCqxitBQmh3z Tb1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2kI06ikxewQ1svqr4cBcgeHbdrXOn2mrV3htIHlbS8I=; b=kB11uA0jKvQWZiLaXl/WNqaWyTexPza5xZTosZsHJnZ0VmR+tMG6pRRUXB9BmxNcY9 mXaYHe8I71+YPtNpWKZ9bK4oVHN90SjaLEjGZbh7j0JhNcRn1EE8NkmFNvK3A/L0jf0J XVXwSIy/qsddbYUTGnKEBQlGMEwdWUXbpIC8j3raQcCqKF05WaUgz0xtHt5ZdyTAzxTU P6tTOu17RAQ06454nPDziJcgAchAIJaIQz8CJa5d+2M/C+6SSb2yxGleaGl/kcF+V2Os Ku/EPEwD+iGxAj6EsQs29CswmweaGHeNIuHb1xq+7DqFMmgNXgEcM2V28TKS66wxGaZo ad8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Cs9K04j3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si4521630pfn.94.2019.08.12.08.00.27; Mon, 12 Aug 2019 08:00:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Cs9K04j3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfHLO73 (ORCPT + 99 others); Mon, 12 Aug 2019 10:59:29 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59720 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbfHLO72 (ORCPT ); Mon, 12 Aug 2019 10:59:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2kI06ikxewQ1svqr4cBcgeHbdrXOn2mrV3htIHlbS8I=; b=Cs9K04j3cdzZxwbZLsTm+xC7U pduUawhaPsZ8z5CEc2/F7zQrEFrMX5pVtB9JY+xe/jt6hbzs2YpD0KPgYTvVOE8xlRCMl5vhAxjkK Q2IbvDxV4+DOTyYEQTg6ruh+sDJHN23ZcwRma5EPve3xoM0xFheuId8M69IIznLCkKnTYE99teYEe V0zrQRhiRo8ftvdSFgqUv3pi0bBiUnMLSRgnbvf2wZH08S+bo8fb92N7oGoX4dhGUi6A3c276SO0i Tsdv1cw+KK9HCCt+YMir9yg5pq3U0e4mj+qLRGeKcWI67Lje73j8SH7xW5ZB7ApWh/+8ptl646hVw w8Rbk7YpA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxBnE-0003nb-EN; Mon, 12 Aug 2019 14:59:28 +0000 Date: Mon, 12 Aug 2019 07:59:28 -0700 From: Christoph Hellwig To: Vincent Chen Cc: paul.walmsley@sifive.com, palmer@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] riscv: Make __fstate_clean() can work correctly. Message-ID: <20190812145928.GE26897@infradead.org> References: <1565251121-28490-1-git-send-email-vincent.chen@sifive.com> <1565251121-28490-3-git-send-email-vincent.chen@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565251121-28490-3-git-send-email-vincent.chen@sifive.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe s/can //g in the subject? > + regs->sstatus = (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN; No need for the inner braces here either. Otherwise: Reviewed-by: Christoph Hellwig