Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3893878ybl; Mon, 12 Aug 2019 08:05:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoeDN8v228MpdeftOZnGACuZb+pmaHg5+qlIkqn2HXmCmIZFIdz5mGes0ufUuxTDUAkHGv X-Received: by 2002:aa7:9393:: with SMTP id t19mr7197374pfe.12.1565622358858; Mon, 12 Aug 2019 08:05:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565622358; cv=none; d=google.com; s=arc-20160816; b=lQeIgCDhCP7/VPtNHInrtWUgaQH8SyWb2UOcuZlTQj0C3I9h5lMKx2IjN8UZMXvwmW Z6NzdmpBpCZokgxp0K37G/L8Ano8fknkoNeJC1/GCOu3CmyopOEKuTZOHtvw1u13oRHu yabHLMufv8boQ2qFGopC9fy/3reJHq2z2qIaheEb5xT0hzjt2Y7JKbqKwx/ixTNl2ocC bc64CJD2egktzyzmTUnnXsbtb+FrbdtQefJyle83wRcPiyiJAfbdi/rzR5DMa/gkVtbG LTiBBveoLwSR/EO3nz3zqP16czTLIsyvcWDKjaQt1Afa+nwesG41QAZFlLJ6Pc9Rvjyj /e6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6aCiFlnKco+0K9lO1zC0yDoDsxtxBScYx2o5eR9m57E=; b=Lgcs4dDzDxxrxaMl8ZE0P4adwkXCtk1npQwLmxTBYgiFPbP+p4MmmaqirzAw9+40rA XfIFNwdlrxoh210bV9c1epgCVTYPDOW9yUoCHaqJ37O07oP1JSAKfKp+/kj89CN2hg2d KOfupmk1vFScooZrP5wHKt/mRjVHMd0CcLQvdORsUIpAd7q1+HLXQnj2OKGyBf3bZHRv v+qFXK8sQFH8VW3dUOMe5RgR3yDX/Y6xmMrV7IqUK2L1+Sova7A+fQnwce5xoAeBeWSi FP5fiFL5e3d9BXrAtJoHkcRnDOhxg6h5XwCsQNiLNi553SD+P7mlCO8Vd4s2zGpJDara f4tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="MKEH/3uB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b13si62573267pfo.59.2019.08.12.08.05.43; Mon, 12 Aug 2019 08:05:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="MKEH/3uB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbfHLPEz (ORCPT + 99 others); Mon, 12 Aug 2019 11:04:55 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39558 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbfHLPEy (ORCPT ); Mon, 12 Aug 2019 11:04:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6aCiFlnKco+0K9lO1zC0yDoDsxtxBScYx2o5eR9m57E=; b=MKEH/3uBkNtMCl1v1WQCg8Yve WIvj1l1zKBBw6Qx6s2Gf1Oj0kUOjDC1hOvcql7jGmAN9IoMlxQLez8jTOZv2BV8uPvlqN8+oU9jdE qm+4Evt3tvu+FoKcMs0blpEDvm8KySvmbfglhZcnciFgskFxcft7uPS6hd9zKV7+B2aAvF1+27j6F WW9bkw/+bJWhE6QUvbUsoOnMrK+Jq68EXv/qj26lk1sh7BIG9+0q+8OiOMXMKLtXvGltBqoZYr7Lf UkXzALFJCZvrSW0zD2g4AJrwtvfFS7Zxc7zmK5jATxDtf+oLnsTnw6qQ+QAHA11hVsGPVRENnvLXw 8oMsqq24g==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxBsN-0006Xf-19; Mon, 12 Aug 2019 15:04:47 +0000 Date: Mon, 12 Aug 2019 08:04:46 -0700 From: Christoph Hellwig To: Nick Hu Cc: alankao@andestech.com, paul.walmsley@sifive.com, palmer@sifive.com, aou@eecs.berkeley.edu, green.hu@gmail.com, deanbo422@gmail.com, tglx@linutronix.de, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com, Anup.Patel@wdc.com, gregkh@linuxfoundation.org, alexios.zavras@intel.com, atish.patra@wdc.com, zong@andestech.com, kasan-dev@googlegroups.com Subject: Re: [PATCH 1/2] riscv: Add memmove string operation. Message-ID: <20190812150446.GI26897@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 03:19:14PM +0800, Nick Hu wrote: > There are some features which need this string operation for compilation, > like KASAN. So the purpose of this porting is for the features like KASAN > which cannot be compiled without it. > > KASAN's string operations would replace the original string operations and > call for the architecture defined string operations. Since we don't have > this in current kernel, this patch provides the implementation. > > This porting refers to the 'arch/nds32/lib/memmove.S'. This looks sensible to me, although my stringop asm is rather rusty, so just an ack and not a real review-by: Acked-by: Christoph Hellwig