Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp115142ybl; Mon, 12 Aug 2019 12:45:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAQYskPIv+xd7J1QvYQMegR5tW0ytNPvSFzpfavzXhJG/mJn/Obzl5TNbnzuHHjhTG91Zn X-Received: by 2002:a65:640d:: with SMTP id a13mr13083502pgv.256.1565639149667; Mon, 12 Aug 2019 12:45:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565639149; cv=none; d=google.com; s=arc-20160816; b=C3H9BOOpNs1tgb0zi5yCv2Fxnc7NV/L5KAhiBx2kH+z8KJZVdXejw5qw60f5OE5c87 zjOv/VIR2BWSDC+WFJ9MHCQW6B9BCUbO3YOw3U14xkTzoS/YaCEVHvBTV0h9GfE5nrnb awXt4jR76oSkBtCFEWxpbC8BrTNWtYJJLKuVx1wSB0rll0SH0DjhP4CsvgxzQULjua9i fwlw21fFmTDBAhi2Uby/Ripgx8LJFf/h3pnXf7OJemgQ3BRhpmydy5ZrKuu8FwCvx5X9 5pY0ijzzkRmgZUmQmNN9Y/CdvMuKJvWBc2cTS6ALb8+zJJxkt7FuwF32i0yVEIdoU/2F 0CuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=OU8IJv/lYjVdyGsKoyblYg4ib4y7MVh+DIjHamncxq8=; b=FGGDR3mXvg9omZrencvV+4A6yj1Xv9v3TgezEo/vhyOpe9ukdEq3bASzQ1RkUHoJ4D M1aWFHM4KktDiCpTNqlViVJptgAZRebFb/NXgxPEojXeFsXLenakSzHFRhYWZ05G4SwC BljemRYZZ+ZmkTAPKic0FBupDuRR6s+Dp+aLt1p1MW2T88tupAg/K49R0GL3pVk/V2vX lLO7v/G+NWut8pcO+dTUbXI9InbbELi3FOgq+9ETUkVW0lEsGJ+0QduP5jmMyCV85d9H bk3lWab1aXvXwfUbOZZarQj6IvoJ12ERng1ekYm6VtG6IJOJhX9LOCIhv0Q5XskuAB1b tn5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=AejkOoxo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si301976pjf.60.2019.08.12.12.45.13; Mon, 12 Aug 2019 12:45:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=AejkOoxo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726961AbfHLTme (ORCPT + 99 others); Mon, 12 Aug 2019 15:42:34 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8775 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfHLTmd (ORCPT ); Mon, 12 Aug 2019 15:42:33 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 12 Aug 2019 12:42:44 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 12 Aug 2019 12:42:33 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 12 Aug 2019 12:42:33 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 12 Aug 2019 19:42:30 +0000 Subject: Re: [PATCH] nouveau/hmm: map pages after migration To: Christoph Hellwig CC: , , , , , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ben Skeggs References: <20190807150214.3629-1-rcampbell@nvidia.com> <20190808070701.GC29382@lst.de> <0b96a8d8-86b5-3ce0-db95-669963c1f8a7@nvidia.com> <20190810111308.GB26349@lst.de> From: Ralph Campbell X-Nvconfidentiality: public Message-ID: <1a84e6b6-31e6-6955-509f-9883f4a7a322@nvidia.com> Date: Mon, 12 Aug 2019 12:42:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190810111308.GB26349@lst.de> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565638964; bh=OU8IJv/lYjVdyGsKoyblYg4ib4y7MVh+DIjHamncxq8=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=AejkOoxomaGMhLpZ3pIIkspkKl7sO550hrdwKO5/NA8faapWC8ktyg1xgZmGlUyIT E8+aD/Eyq4DXtfObw2wb1IDfF5rGaB9SY6L/edDp+qrtiD/VZn2zqviiDYtoL2w5RT G2oreIveRctBxGW5KoLgroNOd1BXtk46jBCX4G5NkjDRbfvrDjsc6GOcIcGt2oLG0z UngAn/Ys1zlFjY6Xwh+/SSpg1UNR5ybYE1cK2qp/6NKJvinEEPJHRCwvguTZlofaqS Pfo7VmGAYM9odOp4MO2GNNvVxTKI+kTKn1BcDsQmcysGiShtWpFpnDFVSIWPomC38i YRYBbJfX49njg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/19 4:13 AM, Christoph Hellwig wrote: > On something vaguely related to this patch: > > You use the NVIF_VMM_PFNMAP_V0_V* defines from nvif/if000c.h, which are > a little odd as we only ever set these bits, but they also don't seem > to appear to be in values that are directly fed to the hardware. > > On the other hand mmu/vmm.h defines a set of NVIF_VMM_PFNMAP_V0_* Yes, I see NVKM_VMM_PFN_* > constants with similar names and identical values, and those are used > in mmu/vmmgp100.c and what appears to finally do the low-level dma > mapping and talking to the hardware. Are these two sets of constants > supposed to be the same? Are the actual hardware values or just a > driver internal interface? It looks a bit odd to me too. I don't really know the structure/history of nouveau. Perhaps Ben Skeggs can shed more light on your question.