Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leo Li <leoyang.li@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>,
        Chuanhua Han <chuanhua.han@nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] arm64: dts: ls1088a: Fix incorrect I2C clock divider
Thread-Topic: [PATCH 1/4] arm64: dts: ls1088a: Fix incorrect I2C clock divider
Thread-Index: AQHVTDQ4Ae8WN9+9zkCguoEFMcJTHKb3mOoAgABwPWA=
Date:   Mon, 12 Aug 2019 20:59:24 +0000
Message-ID: <VE1PR04MB66871BA9508765C03449E2598FD30@VE1PR04MB6687.eurprd04.prod.outlook.com>
References: <20190806084223.23543-1-chuanhua.han@nxp.com>
 <20190812141722.GJ27041@X250>
In-Reply-To: <20190812141722.GJ27041@X250>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bec6a755-dead-46ed-e885-08d71f67f50d
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2019 20:59:24.8866
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: leoyang.li@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6365
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, August 12, 2019 9:17 AM
> To: Chuanhua Han <chuanhua.han@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/4] arm64: dts: ls1088a: Fix incorrect I2C clock div=
ider
>=20
> On Tue, Aug 06, 2019 at 04:42:20PM +0800, Chuanhua Han wrote:
> > Ls1088a platform, the i2c input clock is actually platform pll CLK / 8
> > (this is the hardware connection), other clock divider can not get the
> > correct i2c clock, resulting in the output of SCL pin clock is not
> > accurate.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
>=20
> @Leo, looks good?

Yes.

Acked-by: Li Yang <leoyang.li@nxp.com>

>=20
> Shawn
>=20
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 20f5ebd..30b760e 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -324,7 +324,7 @@
> >  			#size-cells =3D <0>;
> >  			reg =3D <0x0 0x2000000 0x0 0x10000>;
> >  			interrupts =3D <0 34 IRQ_TYPE_LEVEL_HIGH>;
> > -			clocks =3D <&clockgen 4 3>;
> > +			clocks =3D <&clockgen 4 7>;
> >  			status =3D "disabled";
> >  		};
> >
> > @@ -334,7 +334,7 @@
> >  			#size-cells =3D <0>;
> >  			reg =3D <0x0 0x2010000 0x0 0x10000>;
> >  			interrupts =3D <0 34 IRQ_TYPE_LEVEL_HIGH>;
> > -			clocks =3D <&clockgen 4 3>;
> > +			clocks =3D <&clockgen 4 7>;
> >  			status =3D "disabled";
> >  		};
> >
> > @@ -344,7 +344,7 @@
> >  			#size-cells =3D <0>;
> >  			reg =3D <0x0 0x2020000 0x0 0x10000>;
> >  			interrupts =3D <0 35 IRQ_TYPE_LEVEL_HIGH>;
> > -			clocks =3D <&clockgen 4 3>;
> > +			clocks =3D <&clockgen 4 7>;
> >  			status =3D "disabled";
> >  		};
> >
> > @@ -354,7 +354,7 @@
> >  			#size-cells =3D <0>;
> >  			reg =3D <0x0 0x2030000 0x0 0x10000>;
> >  			interrupts =3D <0 35 IRQ_TYPE_LEVEL_HIGH>;
> > -			clocks =3D <&clockgen 4 3>;
> > +			clocks =3D <&clockgen 4 7>;
> >  			status =3D "disabled";
> >  		};
> >
> > --
> > 2.9.5
> >