Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp237869ybl; Mon, 12 Aug 2019 15:23:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8/MCzsqkSAMrsAFQ6fn2l/LNmVu3CGCCbu63DRZD2j1pbM64dOtb9cMlQpUHfWnYXcsrQ X-Received: by 2002:aa7:9903:: with SMTP id z3mr534227pff.200.1565648618162; Mon, 12 Aug 2019 15:23:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565648618; cv=none; d=google.com; s=arc-20160816; b=jqPJrC498Kmbin7tmh5qQlFuSafaU2ZIhMOkoAOoAm12MeEQeWLVBB85PZv9Gtv6oC v4Oy0z/ROTlcCngf5voXLVOlp7DaWEYJ+pIGdjY6dg+qeRCq5bu3enXZaEQAO3uIJiEG xc8nDaw+ZKZmOGGP1Kxc/NfnNIqTlcMPJkObeYjdJ4LxlRSU16x4zmE/gZn2kDv/nlz1 +gE+/43apdprzvthKvi9AjFv+CCUO82lbJkVDMWcX/0LBfdG8HubvTtzYMa/93wQkChN pi9IQtUvcTyzBdg5VZUJb3YV+ejFBdF2hCkf/wF8vsdbsfV9vWC6gTXX3M1UzbrKACv2 K2og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=uQPl7D4DEl8AVSuP+2Fq2Helx9cv9AvXMSaieCMT7oA=; b=C8ukPJ/0euVVcJ9fenEujbldAYl70x6lpz1yGk+wH9fZHVGJA41XLjAyB8FDm6qBAH +rO1q85YKz2V6jENqYpJVi50VVC9YG9z+r5YpW/Ea5J6ZJmxC7jboIsroLuDy0BrxSiu +DUEOJVC6cURZoEysRpRSVuZgRIZX0mNv87WSI3osBqOraF40gqc7daa3ynBjI3xcdbo b6tYIFcM+2tCU+tqpcy8AVkhne8dLtxEIli1jsTSSJelr6ZGGwgju5SzlH3LnWao5Snu RhRCUc1bz+aaE3P7GEy9OXqiWrTrD9S5ku0lFvm1RpR2lvip9GYKXWN2X750XNe72vpH iqOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=lDBMVyRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f98si41440470plb.256.2019.08.12.15.23.20; Mon, 12 Aug 2019 15:23:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=lDBMVyRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbfHLWVx (ORCPT + 99 others); Mon, 12 Aug 2019 18:21:53 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:13137 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbfHLWVw (ORCPT ); Mon, 12 Aug 2019 18:21:52 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 12 Aug 2019 15:21:52 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 12 Aug 2019 15:21:50 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 12 Aug 2019 15:21:50 -0700 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 12 Aug 2019 22:21:50 +0000 Subject: Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote() To: Ira Weiny CC: Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , LKML , , , References: <20190812015044.26176-1-jhubbard@nvidia.com> <20190812015044.26176-3-jhubbard@nvidia.com> <20190812220340.GA26305@iweiny-DESK2.sc.intel.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: <0b66c1f8-c694-7971-b2d3-e1dd53a0f103@nvidia.com> Date: Mon, 12 Aug 2019 15:21:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190812220340.GA26305@iweiny-DESK2.sc.intel.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565648512; bh=uQPl7D4DEl8AVSuP+2Fq2Helx9cv9AvXMSaieCMT7oA=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=lDBMVyRnFKunGUOR/0vpLpZtJOa9QH7VEGqfPR59AhGyeeukIzGUoz9b2kBImVw7H y8cnr9Sd//+TBEcrXo9JyNphHRFzRQgJ85myw2lNi+kM6UpUUnytx9+GhUeXP9FKZ3 RgoJQNeEGGMUnduEAVPhVoM3HZX/ST0NXgedIKw8OttfofCcgaRwxUvU0yjmLHTOzG m5CZ8Z7yajenjJDzRcT7W+lJF+01cDcxKn2xWig68moCWvUMubbCMJ6xnFNn5c/Kga oo7WH7P6nyLqX/egqMWZyT9SX3Cawy0d9q4Ay6DRQakwmqgJWdNqonVaHWGMH2xGSU 8GUs/eRg3PT6Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/12/19 3:03 PM, Ira Weiny wrote: > On Sun, Aug 11, 2019 at 06:50:44PM -0700, john.hubbard@gmail.com wrote: >> From: John Hubbard ... >> +/** >> + * vaddr_pin_pages pin pages by virtual address and return the pages to the > > vaddr_pin_pages_remote > > Fixed in my tree. thanks. :) > >> + * user. >> + * >> + * @tsk: the task_struct to use for page fault accounting, or >> + * NULL if faults are not to be recorded. >> + * @mm: mm_struct of target mm >> + * @addr: start address >> + * @nr_pages: number of pages to pin >> + * @gup_flags: flags to use for the pin >> + * @pages: array of pages returned >> + * @vaddr_pin: initialized meta information this pin is to be associated >> + * with. >> + * >> + * This is the "vaddr_pin_pages" corresponding variant to >> + * get_user_pages_remote(), but with FOLL_PIN semantics: the implementation sets >> + * FOLL_PIN. That, in turn, means that the pages must ultimately be released >> + * by put_user_page(). >> + */ >> +long vaddr_pin_pages_remote(struct task_struct *tsk, struct mm_struct *mm, >> + unsigned long start, unsigned long nr_pages, >> + unsigned int gup_flags, struct page **pages, >> + struct vm_area_struct **vmas, int *locked, >> + struct vaddr_pin *vaddr_pin) >> +{ >> + gup_flags |= FOLL_TOUCH | FOLL_REMOTE | FOLL_PIN; >> + >> + return __get_user_pages_locked(tsk, mm, start, nr_pages, pages, vmas, >> + locked, gup_flags, vaddr_pin); >> +} >> +EXPORT_SYMBOL(vaddr_pin_pages_remote); >> + >> /** >> * vaddr_unpin_pages_dirty_lock - counterpart to vaddr_pin_pages >> * >> @@ -2536,3 +2568,21 @@ void vaddr_unpin_pages_dirty_lock(struct page **pages, unsigned long nr_pages, >> __put_user_pages_dirty_lock(vaddr_pin, pages, nr_pages, make_dirty); >> } >> EXPORT_SYMBOL(vaddr_unpin_pages_dirty_lock); >> + >> +/** >> + * vaddr_unpin_pages - simple, non-dirtying counterpart to vaddr_pin_pages >> + * >> + * @pages: array of pages returned >> + * @nr_pages: number of pages in pages >> + * @vaddr_pin: same information passed to vaddr_pin_pages >> + * >> + * Like vaddr_unpin_pages_dirty_lock, but for non-dirty pages. Useful in putting >> + * back pages in an error case: they were never made dirty. >> + */ >> +void vaddr_unpin_pages(struct page **pages, unsigned long nr_pages, >> + struct vaddr_pin *vaddr_pin) >> +{ >> + __put_user_pages_dirty_lock(vaddr_pin, pages, nr_pages, false); >> +} >> +EXPORT_SYMBOL(vaddr_unpin_pages); > > Rather than have another wrapping call why don't we just do this? Would it be > so bad to just have to specify false for make_dirty? Sure, passing in false for make_dirty is fine, and in fact, there may even be error cases I've forgotten about that *want* to dirty the page. I thought about these variants, and realized that we don't generally need to say "lock" anymore, because we're going to forcibly use set_page_dirty_lock (rather than set_page_dirty) in this part of the code. And a shorter name is nice. Since you've dropped both "_dirty" and "_lock" from the function name, it's still nice and short even though we pass in make_dirty as an arg. So that's a long-winded, "the API below looks good to me". :) > > > diff --git a/mm/gup.c b/mm/gup.c > index e77b250c1307..ca660a5e8206 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2540,7 +2540,7 @@ long vaddr_pin_pages_remote(struct task_struct *tsk, struct mm_struct *mm, > EXPORT_SYMBOL(vaddr_pin_pages_remote); > > /** > - * vaddr_unpin_pages_dirty_lock - counterpart to vaddr_pin_pages > + * vaddr_unpin_pages - counterpart to vaddr_pin_pages > * > * @pages: array of pages returned > * @nr_pages: number of pages in pages > @@ -2551,26 +2551,9 @@ EXPORT_SYMBOL(vaddr_pin_pages_remote); > * in vaddr_pin_pages should be passed back into this call for proper > * tracking. > */ > -void vaddr_unpin_pages_dirty_lock(struct page **pages, unsigned long nr_pages, > - struct vaddr_pin *vaddr_pin, bool make_dirty) > +void vaddr_unpin_pages(struct page **pages, unsigned long nr_pages, > + struct vaddr_pin *vaddr_pin, bool make_dirty) > { > __put_user_pages_dirty_lock(vaddr_pin, pages, nr_pages, make_dirty); > } > EXPORT_SYMBOL(vaddr_unpin_pages_dirty_lock); > - > -/** > - * vaddr_unpin_pages - simple, non-dirtying counterpart to vaddr_pin_pages > - * > - * @pages: array of pages returned > - * @nr_pages: number of pages in pages > - * @vaddr_pin: same information passed to vaddr_pin_pages > - * > - * Like vaddr_unpin_pages_dirty_lock, but for non-dirty pages. Useful in putting > - * back pages in an error case: they were never made dirty. > - */ > -void vaddr_unpin_pages(struct page **pages, unsigned long nr_pages, > - struct vaddr_pin *vaddr_pin) > -{ > - __put_user_pages_dirty_lock(vaddr_pin, pages, nr_pages, false); > -} > -EXPORT_SYMBOL(vaddr_unpin_pages); > thanks, -- John Hubbard NVIDIA