Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp564972ybl; Mon, 12 Aug 2019 22:25:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7ZYfMqrBKuLLLPC33c2M3/Mn5anFCjk0qQDjPuvkZQXMK0G0ot7jUkhcKyxO65n7/r8to X-Received: by 2002:a63:2264:: with SMTP id t36mr31640358pgm.87.1565673954065; Mon, 12 Aug 2019 22:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565673954; cv=none; d=google.com; s=arc-20160816; b=LQLoSvuXN4w5Vt9qZjirWDmAulhWZCgTg1u1LOkx1qagNz5z51MiOS3K9cE6pphAbo UVKWwqMS+C5sv2OYXFPOrQQ6QT/t/BV2b53l/pZB6Fq7i648H6BW7/796iEOipvkvX5P 3X3n4TKzAlTrNfnm0pitBAMQ/F+F+0U/opF8uM4rE7+ox/2sKuHp6X969dkzwOENSIQW 7eAi7GJ0R0O+NviOI+YhzaK9XtQV1gJ2KjO1z7//gLyYUPrCayURE/r6wOJMVcsapedZ KEQsjV/fgKl+Wpz8iVXoQrcyK+Nczlp79aXV1iH4jPfqDiWMPVPu/rogO6THzq7zW/hw vehg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=Jb+OWRcyqMkZoIaXh8KeYMdDqBNAlNwXyy+OBDwOj2g=; b=nHce9IrdErSf1aY+8RSQW+DhizeLtxuDhnkz4m0AKWNfSMWUIjMSdXz/H7Z4P31bX1 VMSPsYYto//lpQqNCjK9m2wkxtOh9W1edgNILw869D4PW1JRULvqJzYCxZuy0DLNrWgh BsuGv2YanYKcIVX5kwIKdfu9Q3Lj+LT0E0RkwbcRKmOSxzvSnCOp/yicXkckbylQB6td 6l5Ah0s7PZcr6HXVDgFfnDDgVQqc7nr5bQQzSwPUEZ4YkV+gXZed6y98YnVRgUftJqhX /f+Z8COevIx2s144b4J20jpQu3J1xIrdSLBpmzz3esi+UQnQK/a5tWNPtYjY/D1j1YM9 1fIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si1301160plo.373.2019.08.12.22.25.36; Mon, 12 Aug 2019 22:25:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfHMFPh (ORCPT + 99 others); Tue, 13 Aug 2019 01:15:37 -0400 Received: from mga07.intel.com ([134.134.136.100]:17191 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfHMFPh (ORCPT ); Tue, 13 Aug 2019 01:15:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 22:15:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,380,1559545200"; d="scan'208";a="166950923" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by orsmga007.jf.intel.com with ESMTP; 12 Aug 2019 22:15:33 -0700 From: Felipe Balbi To: Roger Quadros , Heikki Krogerus , Pawel Laszczak Cc: "gregkh\@linuxfoundation.org" , "linux-usb\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "jbergsagel\@ti.com" , "nsekhar\@ti.com" , "nm\@ti.com" , Suresh Punnoose , Jayshri Dajiram Pawar , Rahul Kumar , Anil Joy Varughese Subject: Re: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver In-Reply-To: <679b82bc-9f33-91ad-4acf-bf6a29e51bc1@ti.com> References: <1563733939-21214-1-git-send-email-pawell@cadence.com> <1563733939-21214-6-git-send-email-pawell@cadence.com> <88742d5b-ee10-cf4e-6724-58e7bdd19cb9@ti.com> <1e557bcf-2d50-f600-0e81-1f9fba5499a1@ti.com> <20190812103147.GA4691@kuha.fi.intel.com> <874l2mtuu6.fsf@gmail.com> <679b82bc-9f33-91ad-4acf-bf6a29e51bc1@ti.com> Date: Tue, 13 Aug 2019 08:15:32 +0300 Message-ID: <87v9v1bq8b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Roger Quadros writes: >> Roger Quadros writes: >>>> The sysfs file we expose from the class for the role switches is >>>> primarily meant for supporting proprietary protocols that require us >>>> to basically override the connector USB data role. The default role >>>> should always be selected in the drivers. >>> >>> OK. Let's take this example >>> - Port is dual-role port micro AB. >>> - microAB to type-A adapter is connected which pulls ID low. port transitions >>> to "host" role by the controller driver. >>> - proprietary protocol want to switch role to device role so writes "device" to >>> mode switch sysfs. port transitions to "device" role. >>> >>> Now, how does controller driver know to fall back to HW based role switching? >> >> Use a 'disconnect' or 'suspend' event to go reset it? But that should, >> probably, be done at kernel space, no? >> > > Yes that could be one option. > So after a disconnect, sysfs role should reflect actual hardware role. correct? that would be my expectation -- balbi