Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp710744ybl; Tue, 13 Aug 2019 01:10:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyf/0EJOXi/IJehaEMhbd8M33mKH8hi69M9/UnAMmityu4lNyMtzQUr7kC8muEAb4jzQkjN X-Received: by 2002:a63:5945:: with SMTP id j5mr33175872pgm.452.1565683827170; Tue, 13 Aug 2019 01:10:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565683827; cv=none; d=google.com; s=arc-20160816; b=sllYPygOfISTjy5id8vTVoikezGNHan2GQpOmKijlMz1wOe3t7wKWZifk5rPrEUrsE 6ZVBZlrSLHTDTSq9tnsAkdVIriYrTs0ukABiK8pNkdljwwnZoc6+7hK7U0kg+DE7LPws NGqlwtXI5ra2c+J7dqI/brhERRhrcbBJYs8+S2YXQoKQGIBqwVy5/krt/opRO58rmgVG E4nsD7eWpA8G9KsH2KXq3pSmpR2rwGMUNOYr2lOM8LYQT4cchW71m4wJhBn3l+O88Ao1 CKj0Z9ntt5FuTw2gO/iOl00jP1aZWeX5iLSSvsY2PeFwT9mZ1vvdmtXTFzv9KmQPw/Qy CNag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TvZfKXBWT9Z9g902906G7WIPUY9iKv6XjXyYLjYmEBc=; b=SsBtPpJRX+Ko4a9/vNmWup6YEbTuAzMxS5SaZusUVsK4ETtiSLBgPEExqwfE/OYHLb xX4GAon0o7qTYTXBCHEKJ5oqBDyhuuejN+vX2Ar+DOIITWbyzCCpW0Egr2alN7D97F05 sg/IFzhZtk13+QGqYL3BOBtObr+QNM9WA1I2Gbtu5rvmXaZ71yfEjuLmwlEfv4m6ubCT mrab0+gfLBtlFdSb+rAyNyqeqhh2u5iHcXWtYtPTwt4kOlk2MADYg9arCulGoVkMkMU8 CW2FNbG4mYm6eVdavGf9g/yIcTzRP/wygMek2wKDeSNErNFMX16hG+z3g1ojnBBwt83N x7ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Hjlrm8LH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92si59636483plc.217.2019.08.13.01.10.10; Tue, 13 Aug 2019 01:10:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Hjlrm8LH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbfHMIJK (ORCPT + 99 others); Tue, 13 Aug 2019 04:09:10 -0400 Received: from mail.skyhub.de ([5.9.137.197]:49706 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfHMIJJ (ORCPT ); Tue, 13 Aug 2019 04:09:09 -0400 Received: from zn.tnic (p200300EC2F0D240075AA4C13F769B7E7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:2400:75aa:4c13:f769:b7e7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 83D2F1EC0716; Tue, 13 Aug 2019 10:09:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565683748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TvZfKXBWT9Z9g902906G7WIPUY9iKv6XjXyYLjYmEBc=; b=Hjlrm8LHktrNd92h9p56qukqrVGVOUmod6fAuuDp//GAFXYEeqeorH2Al/euKE4Sc5h8W3 uTOpVGdpGveXaAhq7RIaWFMlcBV0IuuXRGE2t3d/4RQzxs4DnzmJH0JYMp/bVpM8Y3jnFv Tuz6B1EcaIpFK9fI8EnNCZajiGikD14= Date: Tue, 13 Aug 2019 10:09:58 +0200 From: Borislav Petkov To: Robert Richter Cc: James Morse , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/24] EDAC, ghes: Remove pvt->detail_location string Message-ID: <20190813080958.GC16770@zn.tnic> References: <20190624150758.6695-1-rrichter@marvell.com> <20190624150758.6695-4-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190624150758.6695-4-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 03:08:59PM +0000, Robert Richter wrote: > The detail_location[] string in struct ghes_edac_pvt is complete s/complete/completely/ > useless and data is just copied around. Put everything into > e->other_detail from the beginning. > > Signed-off-by: Robert Richter > --- > drivers/edac/ghes_edac.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.