Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp727076ybl; Tue, 13 Aug 2019 01:29:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAN0Syn4tjfD0YCZL0qSRTbYxsDfaDdueF4hHkLOE7KM+HEyhibk1kYWXAR4eHzMLWdobG X-Received: by 2002:a17:90a:feb:: with SMTP id 98mr1070778pjz.55.1565684953097; Tue, 13 Aug 2019 01:29:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565684953; cv=none; d=google.com; s=arc-20160816; b=SDwaxx8Ley0YYw4Ba+coU+R/FQrgXVuBIn8Ru/J1dKXq69De4v6hhYSv2LZtcoITin Y+IERlbKpfywR2BrVZYJ3is3zTrKlQ8LuGcvF4UwaJXiARKaF0LC00k0Wo7X3i1TP3+f RNxT0sBd6BpicjBTYHhQI825UcEE/HU36YKhMPQt9p4pJgQ684D5HBOs17ad69XFFqvd mgDdrjnZQPN0cc6qSB/2+pmqDu8z92TFhERqhbYGw3MwBOPrQidd9056lHtmSvXUGBx1 ELgxyOII2vhw2qnsVIJIV5Pbxx4sINN1sZtBn5hy5jj8a9nVkseKopLtcoI9rGL3xp2y 0Zog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l3gOxg9cDNbfEo+QFs5wJIXq1nA0q7JIFWh6Fy6/Gzw=; b=eMnh9ow38O1HxZ56OwVYaqKS2mJYVyW2XU1kfDJtFHfoUsx/o5NfDKMBg9mfsuvrDr D4C4XYPOBJaIaAL4NnZxBOzqiXMqmXg/LtloZO37muhb4ocLv19byN0/69dzY+sGEy7/ hfIfc4t3heBX35qQNwgGjHLdDGj8+stxqqLCO/bWhAdnrlIJCXOHUSiAmiwTZZEZfolc rTgKpA6VQZXq7bk7yddEXK7ld/CHiICM2bS/8QwEQV26IvjgubK67wSvvFCodZj5w1IJ KQ+9hUVsLtNb3+CzQZOKs9QVEdGKXwpudMLPYnRNuxc44jHbfNtIkij9uOecJL2q2kK3 0Qtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QkIvwE5t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n63si25046183pga.511.2019.08.13.01.28.57; Tue, 13 Aug 2019 01:29:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QkIvwE5t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728199AbfHMI1x (ORCPT + 99 others); Tue, 13 Aug 2019 04:27:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727777AbfHMI1w (ORCPT ); Tue, 13 Aug 2019 04:27:52 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4CE3820663; Tue, 13 Aug 2019 08:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565684871; bh=ijpfiLD9sMLgqwaHAQaKtfQ0oW53gq9SgIUsFx/EV8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QkIvwE5tYT09KkCFtpJwm7HZLlHqi7YtD2t9dHzFHHbudHhT6m3fHElv7f/famL6V 6RX2sDey0FfjTlcVcY0xV4h11w9BZ4L3bLfmClSBlRNoJ3iznV5dNmefm1i0ut2eGV BMQdBYfRU1YgwtqKokZT9Mj2zs7yUdAEeZEiu9ds= Date: Tue, 13 Aug 2019 09:27:44 +0100 From: Will Deacon To: Nick Desaulniers Cc: akpm@linux-foundation.org, sedat.dilek@gmail.com, jpoimboe@redhat.com, yhs@fb.com, miguel.ojeda.sandonis@gmail.com, clang-built-linux@googlegroups.com, Catalin Marinas , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrey Konovalov , Greg Kroah-Hartman , Enrico Weigelt , Suzuki K Poulose , Thomas Gleixner , Masayoshi Mizuma , Shaokun Zhang , Alexios Zavras , Allison Randal , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h Message-ID: <20190813082744.xmzmm4j675rqiz47@willie-the-truck> References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-12-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812215052.71840-12-ndesaulniers@google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nick, On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > GCC unescapes escaped string section names while Clang does not. Because > __section uses the `#` stringification operator for the section name, it > doesn't need to be escaped. > > This antipattern was found with: > $ grep -e __section\(\" -e __section__\(\" -r > > Reported-by: Sedat Dilek > Suggested-by: Josh Poimboeuf > Signed-off-by: Nick Desaulniers > --- > arch/arm64/include/asm/cache.h | 2 +- > arch/arm64/kernel/smp_spin_table.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Does this fix a build issue, or is it just cosmetic or do we end up with duplicate sections or something else? Happy to route it via arm64, just having trouble working out whether it's 5.3 material! Will