Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     "Razvan.Stefanescu@microchip.com" <Razvan.Stefanescu@microchip.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "joe@perches.com" <joe@perches.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH v2 10/10] staging: fsl-dpaa2/ethsw: do not force user to
 bring interface down
Thread-Topic: [PATCH v2 10/10] staging: fsl-dpaa2/ethsw: do not force user to
 bring interface down
Thread-Index: AQHVUbTHyjGcqRlAKEevkuFP/1mSKQ==
Date:   Tue, 13 Aug 2019 09:43:30 +0000
Message-ID: <VI1PR0402MB28002A870C6EBA30DBA8EBD7E0D20@VI1PR0402MB2800.eurprd04.prod.outlook.com>
References: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com>
 <1565686479-32577-11-git-send-email-ioana.ciornei@nxp.com>
 <9f932adb-fb6d-2973-f5af-6ba9a83be454@microchip.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 569fa08f-7adb-4e71-255f-08d71fd2b360
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2019 09:43:30.7561
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2EE5x+ptT5qJGm5vBiZIwFcCSfy4UWbwAU9HvOCQ2BGbYJlzXeVx4TObwBi/6FxhQ9mg1bA77EQy+iBeSySjiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3376
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/13/19 12:38 PM, Razvan.Stefanescu@microchip.com wrote:=0A=
> =0A=
> =0A=
> On 13/08/2019 11:54, Ioana Ciornei wrote:=0A=
>> Link settings can be changed only when the interface is down. Disable=0A=
>> and re-enable the interface, if necessary, behind the scenes so that we =
do=0A=
>> not force users to an if down/up sequence.=0A=
>>=0A=
>> Reported-by: Andrew Lunn <andrew@lunn.ch>=0A=
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>=0A=
>> ---=0A=
>> Changes in v2:=0A=
>>    - added Reported-by tag=0A=
>>=0A=
>>    drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 32 ++++++++++++++++=
++-------=0A=
>>    1 file changed, 23 insertions(+), 9 deletions(-)=0A=
>>=0A=
>> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/s=
taging/fsl-dpaa2/ethsw/ethsw-ethtool.c=0A=
>> index 0f9f8345e534..99d658fefa14 100644=0A=
>> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c=0A=
>> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c=0A=
>> @@ -88,16 +88,21 @@ static void ethsw_get_drvinfo(struct net_device *net=
dev,=0A=
>>    			 const struct ethtool_link_ksettings *link_ksettings)=0A=
>>    {=0A=
>>    	struct ethsw_port_priv *port_priv =3D netdev_priv(netdev);=0A=
>> +	struct ethsw_core *ethsw =3D port_priv->ethsw_data;=0A=
>>    	struct dpsw_link_cfg cfg =3D {0};=0A=
>> -	int err =3D 0;=0A=
>> -=0A=
>> -	/* Due to a temporary MC limitation, the DPSW port must be down=0A=
>> -	 * in order to be able to change link settings. Taking steps to let=0A=
>> -	 * the user know that.=0A=
>> -	 */=0A=
>> -	if (netif_running(netdev)) {=0A=
>> -		netdev_info(netdev, "Sorry, interface must be brought down first.\n")=
;=0A=
>> -		return -EACCES;=0A=
>> +	bool if_running;=0A=
>> +	int err =3D 0, ret;=0A=
>> +=0A=
>> +	/* Interface needs to be down to change link settings */=0A=
>> +	if_running =3D netif_running(netdev);=0A=
>> +	if (if_running) {=0A=
>> +		err =3D dpsw_if_disable(ethsw->mc_io, 0,=0A=
>> +				      ethsw->dpsw_handle,=0A=
>> +				      port_priv->idx);=0A=
>> +		if (err) {=0A=
>> +			netdev_err(netdev, "dpsw_if_disable err %d\n", err);=0A=
>> +			return err;=0A=
>> +		}=0A=
>>    	}=0A=
>>    =0A=
>>    	cfg.rate =3D link_ksettings->base.speed;=0A=
>> @@ -115,6 +120,15 @@ static void ethsw_get_drvinfo(struct net_device *ne=
tdev,=0A=
>>    				   port_priv->idx,=0A=
>>    				   &cfg);=0A=
>>    =0A=
>> +	if (if_running) {=0A=
>> +		ret =3D dpsw_if_enable(ethsw->mc_io, 0,=0A=
>> +				     ethsw->dpsw_handle,=0A=
>> +				     port_priv->idx);=0A=
>> +		if (ret) {=0A=
>> +			return ret;=0A=
>> +			netdev_err(netdev, "dpsw_if_enable err %d\n", ret);=0A=
> Hello, >=0A=
> These last two lines need to be swapped.=0A=
> =0A=
> Best regards,=0A=
> Razvan=0A=
> =0A=
=0A=
Oops, my bad. Will fix.=0A=
=0A=
Thanks for pointing this out,=0A=
Ioana=0A=
=0A=
=0A=