Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Aug 2019 19:21:16 +0900
Message-ID: <874l2lpdr7.wl-ysato@users.sourceforge.jp>
From:   Yoshinori Sato <ysato@users.sourceforge.jp>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     uclinux-h8-devel@lists.sourceforge.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"
In-Reply-To: <20190730154906.GA18870@roeck-us.net>
References: <20190730154906.GA18870@roeck-us.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 31 Jul 2019 00:49:06 +0900,
Guenter Roeck wrote:
> 
> On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> >  arch/h8300/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> > index ecfc4b4b6373..6974513b1ae9 100644
> > --- a/arch/h8300/Kconfig
> > +++ b/arch/h8300/Kconfig
> > @@ -45,4 +45,7 @@ config NR_CPUS
> >  	int
> >  	default 1
> >  
> > +config BOOT_LINK_OFFSET
> > +	hex	"zImage link offset"
> > +
> 
> "hex" requires a default value. The above declaration generates
> "CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
> and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
> results in "make" requesting a value when it encounters the symbol,
> meaning that automated builds of h8300 images are no longer possible,
> at least not without workarounds.
> 
> Guenter

Sorry too late reply.
OK fixed it.

Thanks your comment.

-- 
Yosinori Sato