Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp835720ybl; Tue, 13 Aug 2019 03:27:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5w4e/toDG9wn03/B2T1a4K1NyxYIuOssKiJw9RLKqXpQ3uwQYo2FalXddTOD+s2wt02rR X-Received: by 2002:a05:6a00:46:: with SMTP id i6mr10843856pfk.196.1565692035963; Tue, 13 Aug 2019 03:27:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565692035; cv=none; d=google.com; s=arc-20160816; b=kbwqkBHSGDEqjHiOyZehsLCOErJJWWlbLcxt12iRHFfbwQrkfUQ150e1dGX+ES7136 fGM8nEFby3+QWViub1QBq4gB67ukHiU4MZ/VtBRv0Ov31VXVfXOsJraHfl4Qy28dRa/J ccc2j1HBWlk90cRy1/fz2y1bIBjrLFzpqDBb22fH8B972GUTAXO6i4gsB+BCC7lSEqm3 uZR9bgtZsfXMhEfbArkPXO2qQX1myUsTZOzZs+Pq9kgKCEl3OkQZk/Eaat6fYXgE27G9 nLwgMGuUX9Yda5GckJG9fDx4Eur8du2zaUTiaIRUG+dx/aWs1hr3Z6X9fNpDetAFa3ri EcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=axGshA9bfoWMZdr+Ibsj6rD5FCXhHKDTOQ0HlXOqr/c=; b=h0pB1X2u3MWUUAZdEINOGT9GzPoLIImzEs1nj/82PPHHTUQaRRnvzvNx0MWH8P1teQ mQIqTFaRN5FGEoeCc/dQACaO4eVKWuXyrOQDA8qC8qekiYakoC5whGAIt4LoOTEY3kGG fBT8yGYE5tQHebrNkepbhIbaX58FgHYgW/eGZEYyR4HyyEUioErNdtgyYCfCKsRZ3FJr gUkyAMAYCRt2q43ButQ2t5xr9/BpiCxJwfdLacLs2gTIomnna61DdBVy+Xuco6cwO6CG osCksDFx/PGfFkJ7vRJZxgNTBDFAuYom8zaxhNTz51pQXQcNnBohGjGhwzQVlGoD3j2j WxyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q32si31209485pgb.408.2019.08.13.03.26.58; Tue, 13 Aug 2019 03:27:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbfHMK0M (ORCPT + 99 others); Tue, 13 Aug 2019 06:26:12 -0400 Received: from muru.com ([72.249.23.125]:57106 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbfHMK0L (ORCPT ); Tue, 13 Aug 2019 06:26:11 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5C791805C; Tue, 13 Aug 2019 10:26:39 +0000 (UTC) Date: Tue, 13 Aug 2019 03:26:08 -0700 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Message-ID: <20190813102608.GK52127@atomide.com> References: <20190811084802.630-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811084802.630-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler and reimplement the > missing operation inside the base FIQ handler. > > Should another dependency - irq_unmask() - be ever removed from the OMAP > GPIO driver, WARN once if missing. Thanks applying into fixes. Tony