Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp844393ybl; Tue, 13 Aug 2019 03:35:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXtRiI1S/Bai9oP7o66MIuavck+iMHy758J8uC0x70Zd8mJ7iVhMVUsnQf1ZTEv1g6uBVW X-Received: by 2002:a63:6ec1:: with SMTP id j184mr13162713pgc.232.1565692534410; Tue, 13 Aug 2019 03:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565692534; cv=none; d=google.com; s=arc-20160816; b=W/cLmSaA84Tlhmm5SPM0V/sdkjn2VWrQ426y9dP8lCO8Z938dPx/xe8QDSvEfbP9hf /YpXAIU9wDMevpHg+lF0D5ddly1/rE8FLWBbYGFjj3ywK5bJDjU67uL+4JzuVGtiuJB/ 6eZZJuVvIi2p87EKle9qVa4J4lr077dtvgxTBMVXLMfmPlUH/5Pp5fzojYijBrsiiyY3 1XmRMgo4yxePmdHrISqgPuEb0OQIgkNiqVHi8IVCIEI2e8Aj6wZOseABc8zWhG/gzAes 7Z3bWpMUHXzvYIrIxsIA3yHN3pyVGjX5AZ+lSIcTe5KGjD0dL04osYnKFUGePh72g/z/ bBqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=6cA5L4nldMuXS3+NB8aKJpkpE3WRzMJpOp2zdKnx0Bo=; b=KloLMjxqEfm/Ky5TmqGyvqsqImE2d8+U/sfMZBp9C7ysB0vcWbG7kKo2nxlefhHLZf qbnpubwfmKXEDbASWlkycAkRjkNxEeQNWyEKCh0g/PgLuXeCC4XG9fQi5lrif4MsQkma czAMZzNPA+lFnnuKemQ2FcFHQpRz9cqQQeBtc2gjv0Rv+2B3h/ylpQyxV5Qg70gGf2Ri 2FtUGMxPlPCipK+GnaOOtlnV28PJcIkyKYYbEe2HVbwPdoNoTR24G5MROM+gFa27H+dC Dxgv1tLX4ptN0hw6KaRRHV5iqQvCS8zKLSzdKUnJYhqz6NvUusSdRFKUmbw6fg+XPueC VsHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si63486146pli.255.2019.08.13.03.35.19; Tue, 13 Aug 2019 03:35:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbfHMIyy (ORCPT + 99 others); Tue, 13 Aug 2019 04:54:54 -0400 Received: from inva021.nxp.com ([92.121.34.21]:41584 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728189AbfHMIyy (ORCPT ); Tue, 13 Aug 2019 04:54:54 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id BE24C200784; Tue, 13 Aug 2019 10:54:52 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B210420077B; Tue, 13 Aug 2019 10:54:52 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 5DEED20629; Tue, 13 Aug 2019 10:54:52 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: joe@perches.com, andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH v2 06/10] staging: fsl-dpaa2/ethsw: remove unnecessary memset Date: Tue, 13 Aug 2019 11:54:35 +0300 Message-Id: <1565686479-32577-7-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> References: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ethtool core already zeroes the memory before calling .get_ethtool_stats() thus making the memset unnecessary. Remove it. Reported-by: Andrew Lunn Signed-off-by: Ioana Ciornei --- Changes in v2: - added Reported-by tag drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c index 12e33a3a1bf1..0f9f8345e534 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c @@ -149,9 +149,6 @@ static void ethsw_ethtool_get_stats(struct net_device *netdev, struct ethsw_port_priv *port_priv = netdev_priv(netdev); int i, err; - memset(data, 0, - sizeof(u64) * ETHSW_NUM_COUNTERS); - for (i = 0; i < ETHSW_NUM_COUNTERS; i++) { err = dpsw_if_get_counter(port_priv->ethsw_data->mc_io, 0, port_priv->ethsw_data->dpsw_handle, -- 1.9.1