Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp844627ybl; Tue, 13 Aug 2019 03:35:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+l7bdu4YLRLluVEFn+qW6fNfHQo0k/EjOrYv0PU+bM9gd3/QRLELq1qEMlSFCPmFMvD/8 X-Received: by 2002:a17:902:b604:: with SMTP id b4mr21759129pls.94.1565692549627; Tue, 13 Aug 2019 03:35:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565692549; cv=none; d=google.com; s=arc-20160816; b=s6zT3uIELe80YEpQJ2cZGHfF7HiqHEKlzJLwSZVJ/FkOQaR14iKE3sQ1qwEv98bCpT ascCga7T46MIuauwDiR1WAFMQ2dQpSnWQsfxqAeYhXknUxmgfbTGFFPoAgvQ0shDK4Xt 7K7fZGaHjH4U6QS7QDV0fBUWD7/AjWCwS+vhXYt7dSe2ry7xC/6xvgpo+kKentHH17Ce rJPf+mJgD1qUqkSItXaITpKjgBy9/VYm7lm2yMH8utS9FGr4Sfh5fQWN6eQyJ35kKWFf BwddvRomGjo7Gk1C1WmEb/8IZTn9j+U3Hgm+ohLOaouywm9N0E+dU/euLphEwaZp4dvr BbWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=S45mrYo1o9VhIjB1P2UdSRpugpnWyJ9CAT96sbMeWo0=; b=owdizmwOn+DSh4Y3W98XMHdH1Yn6aLq8bvIghwORFGuLfcTDRBLDcZPYlpBFK5GhrP 9mo5nhtuRaEPQxjGpwgVNHQpZKSUpFsMe72P2LnYEipgejTZYAgJWcKvnfr8yt4gv67E 3ud4KOhnQPCi5pQPeFvWBMDEi1KRjbZs5kpnIpk021uLs5WvlFMh1dKkjy8mf+i4Aq/C qUNZHF1uxXdWTXyd5MKnv7LJJzpXe0xxHi45ky3tpFRtKxNzgwyniOpK+qwIdAIK8juD Cp+FBSvh3HpSu04/PkVKnIgriBYR9QQKCq17mrSJtzI+qz9x4gG1oaII7zbCjshFeq68 24+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b24si27871586pgh.41.2019.08.13.03.35.34; Tue, 13 Aug 2019 03:35:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728333AbfHMIzG (ORCPT + 99 others); Tue, 13 Aug 2019 04:55:06 -0400 Received: from inva020.nxp.com ([92.121.34.13]:56134 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728294AbfHMIyz (ORCPT ); Tue, 13 Aug 2019 04:54:55 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 8DB321A02B4; Tue, 13 Aug 2019 10:54:53 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 8179C1A009F; Tue, 13 Aug 2019 10:54:53 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 2E9542060E; Tue, 13 Aug 2019 10:54:53 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: joe@perches.com, andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH v2 08/10] staging: fsl-dpaa2/ethsw: reword error message Date: Tue, 13 Aug 2019 11:54:37 +0300 Message-Id: <1565686479-32577-9-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> References: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the current state, the dpaa2-ethsw driver supports only one bridge per DPSW object. Reword the error message so that this information is much more clear. Suggested-by: Andrew Lunn Signed-off-by: Ioana Ciornei --- Changes in v2: - added Suggested-by tag drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index b69b2b7be972..28da109aef5e 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -1119,8 +1119,7 @@ static int port_bridge_join(struct net_device *netdev, if (ethsw->ports[i]->bridge_dev && (ethsw->ports[i]->bridge_dev != upper_dev)) { netdev_err(netdev, - "Another switch port is connected to %s\n", - ethsw->ports[i]->bridge_dev->name); + "Only one bridge supported per DPSW object!\n"); return -EINVAL; } -- 1.9.1