Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp845189ybl; Tue, 13 Aug 2019 03:36:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVLXz88CLv8x1SwXksdhARk23p6cNpAN3h5w1BW+PwAl+2ATUT3z4ptgHvcBiq8paMcCCR X-Received: by 2002:a17:902:3081:: with SMTP id v1mr37814687plb.169.1565692584588; Tue, 13 Aug 2019 03:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565692584; cv=none; d=google.com; s=arc-20160816; b=iAci8IlfomM+z12XXHxihMWRN7okUTUCyCXcDkNke4nrDaSyPv27fd4cwA52LF9CXH fIcbFuGYqiEqX3Oo1CFKP9XSHQzdge5V2f6wAiiW30YlfIfFfxHgaa7DVAreL2F36iwU arMMutudNb8+/9iqAgRde3W1BwVt2QQ1r6/RFgh5Jfkvd0BE9+s2Ov0N9LLivNYGPwXV RxiffQN6a1ySTRxWFDq7rliGX9SfsEzAJgl6mW/MPHBCIfPayKziXBKsj6gbBk6xJds6 RHRKYO8SNm5k4OkBBOP4J2BEHlVskdsnEivgWlVyWkeE7FA8EE2lDALwsZYA9lC9wWOq h8aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=77NLMNyvsongc9/dtDt+L9Ajm5AT+fIU66KRxpld30Q=; b=00eunrOZJ5ggx2chsn+c/QTKSUdwsZMJah8YTznhFIcIabyErFqiJJ6f26CPLvYbR/ T/qyvNTCIgxWYb8FfT8dWWKHtDdm+t/mPLDwaOO+xcBvj/jN3IGdygnwOi54ZFlwWNM7 kap6AbLr5foc1VYnt6CyRDrEQBiS5H0r23fiizC1jrT7qVDsdx91O3zZQIThy6jdYsjk GsUuvtxOVgB+UjspjEQnVrMpOW79UN6YUKnOD78U6vdPNxoPgKmGXkbneWyJoRAVJz2T FYEgNDEBmnVAsRNbCM7bElldlDkeQipLXgbX6oNL6Xln636zaCCwnuZ3x11yYoZq9rE3 90Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si57096786ply.247.2019.08.13.03.36.08; Tue, 13 Aug 2019 03:36:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbfHMIzZ (ORCPT + 99 others); Tue, 13 Aug 2019 04:55:25 -0400 Received: from inva020.nxp.com ([92.121.34.13]:56112 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727377AbfHMIyx (ORCPT ); Tue, 13 Aug 2019 04:54:53 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 02E431A0765; Tue, 13 Aug 2019 10:54:52 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id EAC7D1A02F4; Tue, 13 Aug 2019 10:54:51 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 98D7F2060E; Tue, 13 Aug 2019 10:54:51 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: joe@perches.com, andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH v2 04/10] staging: fsl-dpaa2/ethsw: remove debug message Date: Tue, 13 Aug 2019 11:54:33 +0300 Message-Id: <1565686479-32577-5-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> References: <1565686479-32577-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since ethtool will be loud enough if the .set_link_ksettings() callback fails, remove the debug messages which do not add additional information. Reported-by: Andrew Lunn Signed-off-by: Ioana Ciornei --- Changes in v2: - added Reported-by tag drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c index 95e9f1096999..12e33a3a1bf1 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c @@ -91,8 +91,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, struct dpsw_link_cfg cfg = {0}; int err = 0; - netdev_dbg(netdev, "Setting link parameters..."); - /* Due to a temporary MC limitation, the DPSW port must be down * in order to be able to change link settings. Taking steps to let * the user know that. @@ -116,11 +114,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, port_priv->ethsw_data->dpsw_handle, port_priv->idx, &cfg); - if (err) - /* ethtool will be loud enough if we return an error; no point - * in putting our own error message on the console by default - */ - netdev_dbg(netdev, "ERROR %d setting link cfg", err); return err; } -- 1.9.1